yarn installation failed with phantomjs path about ngd

[manekinekko]

We're gonna drop phantomjs for now. I was using it to generate PNGs files previously. But now we switched to SVG. So we can remove phantomjs package.

On Sat, Dec 10, 2016, 14:06 Vincent Ogloblinsky ***@***.***> wrote: node : 6.5.0 npm : 3.10.9 yarn : 0.17.10 yarn add angular2-dependencies-graph error /home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/phantomjs: Command failed. Exit code: 1 Command: sh Arguments: -c node install.js Directory: /home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/phantomjs Output: PhantomJS not found on PATH Phantom installation failed TypeError: Path must be a string. Received undefined at assertPath (path.js:7:11) at Object.join (path.js:1213:7) at findSuitableTempDirectory (/home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/phantomjs/install.js:127:30) at /home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/phantomjs/install.js:476:19 at nextTickCallback (/home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/kew/kew.js:47:28) at _combinedTickCallback (internal/process/next_tick.js:67:7) at process._tickCallback (internal/process/next_tick.js:98:9) TypeError: Path must be a string. Received undefined at assertPath (path.js:7:11) at Object.join (path.js:1213:7) at findSuitableTempDirectory (/home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/phantomjs/install.js:127:30) at /home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/phantomjs/install.js:476:19 at nextTickCallback (/home/osboxes/Documents/www/compodoc-demo-todomvc-angular2/node_modules/kew/kew.js:47:28) at _combinedTickCallback (internal/process/next_tick.js:67:7) at process._tickCallback (internal/process/next_tick.js:98:9) info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#43>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABnuHSUGW4TWW2OMbhtnPrqQVtR_JJ97ks5rGqPkgaJpZM4LJpXM> .

-- Wassim Chegham Developer Advocate at SFEIR Google Developer Expert in Web Technologies <http://fr.linkedin.com/in/wassimchegham> <http://twitter.com/manekinekko> <http://plus.google.com/+WassimCheghamJavaScript/posts> <http://flickr.com/photos/manekinekko/albums/> <http://github.com/manekinekko> <http://wassimchegham.com/feed> <http://wassimchegham.com/> <http://www.meetup.com/members/135357292/> <http://slides.com/wassimchegham/>

[vogloblinsky]

Yep, that was my personal conclusion 😄

[manekinekko]

cut a new release https://github.com/manekinekko/angular2-dependencies-graph/releases/tag/v1.0.0-alpha.12

[nweldev]

Ngb releases are a bit confusing. It took me some time to figure out that v1.0.0-alpha.12 comes after v1.0.0. So we can't set this dependency to ^1.0.0-alpha.12 like I did. It would be a good idea to release v1.0.0-alpha.12 as a v1.0.1 to solve this (related to #33)

For now, in order to fix this issue, we have to set the version to a strict 1.0.0-alpha.12, or we can simply add :

"resolutions": {
    "angular2-dependencies-graph/svg-to-png": "3.1.0"
  }

to our package.json if we use yarn (see https://yarnpkg.com/lang/en/docs/selective-version-resolutions/), since there isn't any beacking change between this two versions, at least for how ngb seems to use it.

Related issues :

• yarnpkg/yarn#1016
• Medium/phantomjs#673