GithubHelp home page GithubHelp logo

Comments (6)

LucasHorseshoeBend avatar LucasHorseshoeBend commented on June 3, 2024

The "title" issue and the false positive for German are probably distinct issues.
The title that displays in
http://vmcp.conaltuohy.com/xtf/view?docId=tei/Mueller%20letters/1850-9/1858/58-10-07a-final.xml
is disconcerting, as it is counterintuitive to have to click upon [...] to open the file
There are two others with the same feature in 1858 files:
http://vmcp.conaltuohy.com/xtf/view?docId=tei/Mueller%20letters/1850-9/1858/58-11-00-final.xml
and
http://vmcp.conaltuohy.com/xtf/view?docId=tei/Mueller%20letters/1850-9/1858/58-12-00a-final.xml

but I can't pick up a common feature of those files in Word.
There are eight 1858 files coded German that do have German text that behave as expected.
The three identified above are the only files in 1858 where this issue arises.

I did spot checks:
1840s folders, no such cases when German selected, nor when English selected

1868 folder, one case of the problem when faceted as English, and is in English,
http://vmcp.conaltuohy.com/xtf/view?docId=tei/Mueller%20letters/1860-9/1868/68-12-06-draft.xml
BUT the same file appears with same "title" when I select the in German facet!!

So there is something odd about the recognition of languages also.

from vmcp-upconversion.

LucasHorseshoeBend avatar LucasHorseshoeBend commented on June 3, 2024

The resaving did not eliminate the "title" as [...]
the four files all report as being both English and German
I do not understand this behaviour.

from vmcp-upconversion.

Conal-Tuohy avatar Conal-Tuohy commented on June 3, 2024

Thanks for your detective work, here @LucasHorseshoeBend ; based on your analysis I have got to the bottom of the missing title and the language mis-classification, and they are indeed related, as you surmised.

The immediate cause of the problem in 58-10-07a-final is that the letter contains an empty trailing paragraph which is styled with the style t-letter.

The chain of events leading from that empty paragraph to the text being classified as German and also having a missing title is this:

  1. The paragraphs whose style names begin with t- are assumed to be translations (into English), and the remainder of the letter is, by elimination, assumed to be in German. So that single blank t-letter para is what causes all the text of the letter to be tagged as German.
  2. Because XTF irritatingly requires every TEI document to have a title, which these letters don't generally have, my pipeline has a step which adds a heading which it derives from the opening lines of the letter (an "incipit") suffixed with an ellipsis. In order to give the documents English language titles, the incipit includes only text which has been tagged as English, but in this case the only English language paragraph is that empty t-letter paragraph, so the incipit also ends up empty.

I think that I can fix the whole thing by a small tweak to the translation-recognition step so it ignores paragraphs which are styled as a translation if they are empty.

from vmcp-upconversion.

LucasHorseshoeBend avatar LucasHorseshoeBend commented on June 3, 2024

from vmcp-upconversion.

Conal-Tuohy avatar Conal-Tuohy commented on June 3, 2024

Cheers @LucasHorseshoeBend; since it was a trivial tweak I just went ahead and did it.

from vmcp-upconversion.

LucasHorseshoeBend avatar LucasHorseshoeBend commented on June 3, 2024

from vmcp-upconversion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.