ability to set garden address about concourse-bosh-release

[vito]

What other components use Garden? What do you mean by setting garden address...?

[ramonskie]

bosh lite uses garden.
see https://github.com/cloudfoundry/bosh-deployment/blob/master/bosh-lite.yml

[vito]

Gotcha. Well, from our side we never really intended to share Garden-runC with any other component, and I'm kind of surprised that worked without issue. I don't think we'll be adding this ourselves, but I'd be happy to review a PR assuming it's easy enough to maintain. I suppose you'd need a flag to prevent the worker binary from running its own gdn, and to just use a pre-configured Garden address.

Maybe something like concourse worker --external-garden ip:port? That flag could be added here:

https://github.com/concourse/concourse/blob/9f34dafd8d94ae2ee947aa52fb8de4f0a8fbe49e/cmd/concourse/worker_linux.go#L28-L35

...and in that case it could return a nil runner, though the calling code would have to check for that and know now to try and run it:

https://github.com/concourse/concourse/blob/9f34dafd8d94ae2ee947aa52fb8de4f0a8fbe49e/cmd/concourse/worker.go#L94-L97

[drnic]

This regression in Concourse is blocking upgrade of Concourse Tutorial to v5 (since it switches to deploying BUCC in the middle to introduce credhub secrets)

[drnic]

Also https://ci2.starkandwayne.com runs on the bucc deployment model of concourse (if you’re interested in production envs that use bucc)

[vito]

@drnic If you've got time, a PR making the suggested changes in #17 (comment) would be the quickest route. This was never intentionally supported so I'd hesitate to call it a regression, but I'm happy to bring in explicit support for it.

[rkoster]

@vito 2 PR have been created, to address this issue:

• concourse/concourse#3806
• #27

Looking forward to receiving feedback.

[vito]

all the changes for this are in now 👍