GithubHelp home page GithubHelp logo

Comments (6)

leofang avatar leofang commented on June 25, 2024

I am sure @jakirkham would know better the reason, to me it's simply my lack of knowledge of the proper way to build UCX. I'd say PRs are definitely welcomed.

from ucx-split-feedstock.

pentschev avatar pentschev commented on June 25, 2024

Thanks Leo for the quick reply, I opened #111 to address that.

from ucx-split-feedstock.

jakirkham avatar jakirkham commented on June 25, 2024

Yeah changing this seems reasonable.

The main issue is to make sure UCX isn't changing ABI compatibility of the libraries on rebuild (this can happen as debug libraries sometimes use different symbols). If it does, we might need to think harder about this change to minimize breakage of existing binaries (or coordinate it with a new release).

Most configure scripts have an --enable-debug flag that gets passed to enable debug mode. One can pass --disable-debug mode to be explicit, but that would already be the default. Had assumed this was the case with UCX, but didn't realize something non-standard was done here (maybe there is a reason for this?). Asking if this can be improved on in issue ( openucx/ucx#8642 ).

from ucx-split-feedstock.

jakirkham avatar jakirkham commented on June 25, 2024

Digging deeper into configure-release, it appears it passes --disable-debug along with a few other flags related to logging and assertions back to configure.

from ucx-split-feedstock.

pentschev avatar pentschev commented on June 25, 2024

I'm not sure whether ABI is changed or not to be honest. But I agree with you, maybe waiting for the next UCX release is more appropriate to reduce breakage. What would be the best way to ensure we don't forget about that when the new release is out?

from ucx-split-feedstock.

jakirkham avatar jakirkham commented on June 25, 2024

Maybe we should do this as part of 1.14.0?

from ucx-split-feedstock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.