Comments (2)
Its not as simple as it seems. First of all changing the naming in the proto files will cause a huge collision
between Typescript and gRPC naming conventions.
Also , the gRPC's servers will crash because of rpc messages. ( Cause the naming will be changed).
gRPC Server Implementation
So, in order to solve this problem the gRPC server implementation should be changed.
ts-proto tool must be used in order to auto-generate the proper service/message interfaces.
Using this tool requires to create a Server Class for each module which implements the auto-generated interfaces
But there is a major problem in this solution:
It is difficult to implement a server class for the Router because the proto files are auto-generated.
from conduit.
Yeah the solution seems to require quite a bit of refactoring. I'm trying to understand if we tangled ourselves into this mess or it was bound to get messy either way. We'll need to have a design meeting on discord for this to figure out a proper approach to untangle this thing.
from conduit.
Related Issues (20)
- [FEAT] Implement service provider checks in module initialisation HOT 1
- [FEAT] Auto-generated Bus Events based on Lifecycle Hook Stages
- [BUG] Race condition between Config module and module configuration requests HOT 1
- [Feature]: gRPC Request Protection
- [Feature]: Users should not be capable of unilaterally adding other users to any form of group
- Fix 9 Maintainability issues in multiple files
- [Bug]: Get middlewares route does not work properly
- [Bug]: Database module triggers introspection process on unpopulated dbs
- [Feature]: Security Clients add custom name or notes HOT 3
- [Feature]: Storage provider support Aliyun OSS HOT 1
- [Feature]: Local Storage support url HOT 2
- [Bug]: Cannot start on windows HOT 4
- [Bug]: Form module not serving
- [Feature]: Update Discord invite link HOT 1
- [Bug]: Deleting Schema doesn't remove api from Swagger HOT 1
- [Feature]: Make S3 Storage Generic HOT 2
- [Bug]: [AUTH] Access token not rejected when user is blocked HOT 2
- [Bug]: Error when using SMTP email provider HOT 3
- [Bug]: Configuring Github and gitlab as OAuth provider is swapped HOT 3
- [Bug]: OAuth Url has a surplus question mark HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conduit.