Release 2.3 about cancellationtoken

[rogerfar]

Is this ready for a version bump? I'm interested in the canBeCancelled part, it's helpful when doing react debugging.

[AArnott]

I was just looking at the changes and have a suggestion before we release.

Can we add a test (and product change if required) that shows canBeCanceled changes from true to false when its source has been disposed of?

[AArnott]

If @conradreuter agrees, I can send a PR.

[conradreuter]

Makes sense to me. (:

…

On Thu, Dec 2, 2021, 3:02 PM Andrew Arnott ***@***.***> wrote: If @conradreuter <https://github.com/conradreuter> agrees, I can send a PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUFTSHLT2F7TGDKFXY5YN3UO536DANCNFSM5JFAFCOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[AArnott]

Working on it. @conradreuter I wonder what your development environment is like. I open this repo in VS Code and while tests pass at the command line, they fail in the VS Code "Testing" panel (Test Explorer) because of missing semicolons. Are you able to run tests inside VS Code?

[AArnott]

I found a set of steps to fix it. My PR will include some changes so this works out of the box.

[conradreuter]

IIRC my environment was Ubuntu inside WSL, and then connecting to WSL via VSCode. I most likely just ran the tests from command line in watch mode.