Comments (3)
Hi @jon-chuang, I indeed got confused with the naming convention. BenchmarkG1AffineDouble
is indeed in Jacobian coordinates and the reported timings for gurvy double
are in extended Jacobian. I will update the corresponding data.
To be fair to all libs, I am updating the post as follows:
- correct
arkworks-rs
timings following a assembly bug (arkworks-rs/algebra#192) - add
relic
assembly preset (x64-pbc-bls12-381
) - update
kilic/bls12-381
after recent imporovements - update
constantine
after recent imporovements - add
iden3/ffiasm
to the benchmark
Thank you for opening the issue! Let me know if you notice anything else.
from gnark-crypto.
Hi @yelhousni thanks!
I'm not too familiar with the extended jacobian coordinates, do you know how they are used in gurvy specifically? Meaning, are they used in scalar mul or msm for instance? Just curious as they seem to provide some nice speed results, I was wondering if it's been tested to work well as part of bigger routines.
Currently we are making some simple changes to improve performance across the board arkworks-rs/algebra#205 prompted by these benchmarks, it would be nice to include these improvements while measuring the asm for arkworks.🙏
Another issue is one should use the feature "n_fold" for more accurate benchmarking... The current benchmark framework is not very good for ns-level measurement and hopefully we will be changing it soon.
from gnark-crypto.
Extended Jacobian coordinates are indeed used in gurvy
for MSM.
Let me know when you finish improving arkworks-rs
and I will update the benchmark.
I am using n_fold
feature for cargo bench
.
from gnark-crypto.
Related Issues (20)
- What's the rationale for methods returning pointers in the ecc packages? HOT 3
- bug: invalid marshalling found by fuzzer HOT 2
- iop.Polynomial.Evaluate should work in Lagrange/Lagrange shifted form
- refactor: make applying domain separation optional in Fiat-Shamir Transcript HOT 1
- bug: When dynamic linking, R15 may be clobbered by a global variable access HOT 7
- bug: possibly incorrect `DST_prime` in `ExpandMsgXmd` HOT 6
- Parametrizable mimc endianness HOT 4
- Docu: Merkle tree documentation outdated or hashing of nodes in is incorrect
- Add SetElement to fptower.E2 HOT 2
- BLS12-381 G1 Subgroup checks are slow HOT 7
- feat: MIMC security considerations HOT 2
- Optimize Legendre symbol
- Generator of Fr*
- feat: Implement Poseidon hash
- 📦 `github.com/consensys/gnark-crypto/ecc` HOT 1
- bug: MiMC Write() violates hash.Hash expectations. HOT 5
- feat: add MustSetRandom methods
- Question: is it possible to generate secp256k1 ecdsa Private Key from a secret string? HOT 3
- Question: compatibility between crypto/sha256 and gnark/sha2 HOT 1
- bug: Incorrect ScalarMultiplication in bandersnatch HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gnark-crypto.