Flags not being evaluated at the right time about gb

[davecheney]

Can you check with the latest version, I think I fixed this problem last
night.

To be fair, -goos and -goarch aren't rrally tested, but I know -goroot works

On Sat, 2 May 2015 09:36 Mark Wolfe [email protected] wrote:

Just tried to add -R to override the project root and ran into the fact
that the flags are not evaluated till after the plugins.

After adding a bit of debugging *goroot, *goos, *goarch will only ever
get set to the default values.

https://github.com/constabulary/gb/blob/master/cmd/gb/main.go#L77

vs flags evaluated on

https://github.com/constabulary/gb/blob/master/cmd/gb/main.go#L100

—
Reply to this email directly or view it on GitHub
#26.

[wolfeidau]

I pulled down the latest changes and added.

    gb.Infof("goroot=%s goos=%s goarch=%s", *goroot, *goos, *goarch)
    tc, err := gb.NewGcToolchain(*goroot, *goos, *goarch)

Passed in arm as goarch and it is still set to amd64.

gb build -goarch=arm -goos=linux all

got

2015/05/02 10:18:38 INFO goroot=/usr/local/Cellar/go/1.4.2/libexec goos=darwin goarch=amd64

[davecheney]

Yup, that's a bug. I haven't tested GOOS/GOARCH only changing the toolchain
via -goroot, there is a chance those former values are hard coded.

I'll fix it.

On Sat, 2 May 2015 10:19 Mark Wolfe [email protected] wrote:

I pulled down the latest changes and added.

gb.Infof("goroot=%s goos=%s goarch=%s", *goroot, *goos, *goarch)
tc, err := gb.NewGcToolchain(*goroot, *goos, *goarch)

Passed in arm as goarch and it is still set to amd64.

gb build -goarch=arm -goos=linux all

got

2015/05/02 10:18:38 INFO goroot=/usr/local/Cellar/go/1.4.2/libexec goos=darwin goarch=amd64

—
Reply to this email directly or view it on GitHub
#26 (comment).

[davecheney]

Note, unless you're using go1.5, to do cross compiles you'll have to do
that 'christen your cross compile toolchain dance', gb wont save you from
that, and in fact, it might make it worse as we always consider the
standard library to be up to date irrespective of the toolchain.

On Sat, 2 May 2015 10:22 Dave Cheney [email protected] wrote:

Yup, that's a bug. I haven't tested GOOS/GOARCH only changing the
toolchain via -goroot, there is a chance those former values are hard
coded.

I'll fix it.

On Sat, 2 May 2015 10:19 Mark Wolfe [email protected] wrote:

I pulled down the latest changes and added.

gb.Infof("goroot=%s goos=%s goarch=%s", *goroot, *goos, *goarch)
tc, err := gb.NewGcToolchain(*goroot, *goos, *goarch)

Passed in arm as goarch and it is still set to amd64.

gb build -goarch=arm -goos=linux all

got

2015/05/02 10:18:38 INFO goroot=/usr/local/Cellar/go/1.4.2/libexec goos=darwin goarch=amd64

—
Reply to this email directly or view it on GitHub
#26 (comment).

[davecheney]

@wolfeidau what i'm going to do is close this issue by removing -goarch and -goos. I'll open a new issue to make them work properly.