`crun --version` should show git commit about crun

[rhatdan]

Interested in opening a PR?

[giuseppe]

I've changed the way the version is generated to also include a part of the git commit if there is no tag for the current commit.

Could you please check if it works for you?

$ /usr/bin/crun --version
crun version 0.10.6

$ ./crun --version
crun version 0.10.6.1-1b15

[AkihiroSuda]

thanks, but I prefer runc-compatible output: https://github.com/opencontainers/runc/blob/b9b6cc6e47fe4f2aa4f744a1fc62d248c182d28d/main.go#L62

[carlosedp]

Folks, my PR (moby/moby#39940) has been merged and latest Docker built from master shows correct versions and doesn't print the "unable to parse" messages into the logs:

❯ docker version
Client:
 Version:           unknown-version
 API version:       1.40
 Go version:        devel +c20db960e2 33 hours ago
 Git commit:        7fcd2252
 Built:             Tue Sep 10 15:00:43 2019
 OS/Arch:           linux/riscv64
 Experimental:      true

Server:
 Engine:
  Version:          dev
  API version:      1.41 (minimum version 1.12)
  Go version:       devel +1c193b20a6 3 weeks ago
  Git commit:       a4a0429eec-unsupported
  Built:            Tue Nov 26 13:10:04 2019
  OS/Arch:          linux/riscv64
  Experimental:     false
 containerd:
  Version:          1.2.0+unknown
  GitCommit:
 crun:
  Version:          0.10.3.55-f6af
  GitCommit:
 docker-init:
  Version:          0.18.0
  GitCommit:        3c53686


❯ containerd --version
containerd github.com/containerd/containerd 1.2.0+unknown


❯ crun --version
crun version 0.10.3.55-f6af
spec: 1.0.0
+SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL


❯ docker-init --version
tini version 0.18.0 - git.3c53686

[AkihiroSuda]

GitCommit is still unfilled

[carlosedp]

I've opened PR #192 for this.