bug(ui): Button component cannot have spinner if icon is undefined about podman-desktop

[axel7083]

I'm wondering if we could drop the text in the button completely when clicked and show just the spinner? Then there would be consistency across all the buttons, icon or not. Like this:

Could someone attach what the button looks like atm when loading?

I do think feedback on the button is important only if the load time is greater than a second. I'm not sure if that's already the case here.

InProgress without icon defined

InProgress with icon defined

inprogress-button.mp4

My personal opinion, is that we should have the same spinner, with the text, no matter if we defined an icon beforehand or not.

If we hide the text, the button will look like this

Because the width is dependent on the text. We cannot keep the size and hide the text without dirty hack.

[deboer-tim]

As per PR comment, this is an intentional design choice.

[ekidneyrh]

I'm wondering if we could drop the text in the button completely when clicked and show just the spinner? Then there would be consistency across all the buttons, icon or not. Like this:

Could someone attach what the button looks like atm when loading?

I do think feedback on the button is important only if the load time is greater than a second. I'm not sure if that's already the case here.

[ekidneyrh]

ah okay I see! Thanks for the details.

My personal opinion, is that we should have the same spinner, with the text, no matter if we defined an icon beforehand or not.

I'm going to give this a +1. I agree that it's the best course of action for consistency.

[axel7083]

I'm going to give this a +1. I agree that it's the best course of action for consistency.

I will be re-opening the closed pr thanks !