Comments (5)
I'm wondering if we could drop the text in the button completely when clicked and show just the spinner? Then there would be consistency across all the buttons, icon or not. Like this:
Could someone attach what the button looks like atm when loading?
I do think feedback on the button is important only if the load time is greater than a second. I'm not sure if that's already the case here.
InProgress without icon defined
![image](https://private-user-images.githubusercontent.com/42176370/332767573-65dedc62-4e1e-411a-a65c-7952417990e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkyOTA2OTMsIm5iZiI6MTcxOTI5MDM5MywicGF0aCI6Ii80MjE3NjM3MC8zMzI3Njc1NzMtNjVkZWRjNjItNGUxZS00MTFhLWE2NWMtNzk1MjQxNzk5MGUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDA0Mzk1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzNDM1MDU1NTBhMTkxZTEyMzA4MDI2YzVjNjQ0Mzg0ZTliYmZlNWZkNDAwMjRmMDNlMzQzMGYzNTg0N2MyZmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aw2QnmqdoUbht68AF4HmnAANeQolMjqyda--Q4E9nEw)
InProgress with icon defined
inprogress-button.mp4
My personal opinion, is that we should have the same spinner, with the text, no matter if we defined an icon beforehand or not.
If we hide the text, the button will look like this
![image](https://private-user-images.githubusercontent.com/42176370/332768282-3259c88e-7f78-4f9f-abdb-75869a024b8a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkyOTA2OTMsIm5iZiI6MTcxOTI5MDM5MywicGF0aCI6Ii80MjE3NjM3MC8zMzI3NjgyODItMzI1OWM4OGUtN2Y3OC00ZjlmLWFiZGItNzU4NjlhMDI0YjhhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDA0Mzk1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQwZmI2YjE0NjZlMDY3Yzk3MmI1ZWNhZDRiZmViM2U5MmExNDJkNGI1ZmY1MDU4Y2JiZGNhMjEyNTk0ODZkZGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.h3ud7S-iU0hqPEGOwobFNmmCMS_ydQU6OewlOydUZXs)
Because the width is dependent on the text. We cannot keep the size and hide the text without dirty hack.
from podman-desktop.
As per PR comment, this is an intentional design choice.
from podman-desktop.
I'm wondering if we could drop the text in the button completely when clicked and show just the spinner? Then there would be consistency across all the buttons, icon or not. Like this:
Could someone attach what the button looks like atm when loading?
I do think feedback on the button is important only if the load time is greater than a second. I'm not sure if that's already the case here.
from podman-desktop.
ah okay I see! Thanks for the details.
My personal opinion, is that we should have the same spinner, with the text, no matter if we defined an icon beforehand or not.
I'm going to give this a +1. I agree that it's the best course of action for consistency.
from podman-desktop.
I'm going to give this a +1. I agree that it's the best course of action for consistency.
I will be re-opening the closed pr thanks !
from podman-desktop.
Related Issues (20)
- Objects on Nodes and other kubernetes pages disappear after a while HOT 1
- Ability for extensions to contribute multiple nav items as a group HOT 2
- Main navigation revamp
- Migrate extension nav group to individual nav items HOT 2
- Raise max listeners for electron HOT 2
- Navigation registry HOT 2
- Random preference's fields with a value sometime show and error: Value type provided is number instead of boolean HOT 3
- Separate documentation page on Rosetta support for Mac M1 for building amd64 binaries
- Add "GPU" Label under Roles for Kubernetes clusters that have GPU's detected.
- Air Gap Installation throws Node JS error on Windows 11 with no internet connectivity HOT 3
- Shows undefined for node in rare cases for pods
- Should be able to sort conditions and pods for Deployments
- The authentication `Sign out` command should ask a user for confirmation
- Allow to push image after the build without leaving 'Build Image' page HOT 1
- Support using --build-arg-file for building / supplying a build arg file to build a container. HOT 4
- Unable to see bottom of terminal / input when going to Kubernetes tab with data
- Inconsistent table styling HOT 5
- Add rosetta precheck for macOS
- Display the files present in an image
- add support for zstd compression for extensions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from podman-desktop.