GithubHelp home page GithubHelp logo

Comments (8)

ekidneyrh avatar ekidneyrh commented on June 21, 2024

SVGs:
pvc
pvc-filled

PNGs:
pvc-filled
pvc

Here's a screenshot from inkscape for better visibility :)

image

WDYT?

from podman-desktop.

cdrage avatar cdrage commented on June 21, 2024

SVGs: pvc pvc-filled

PNGs: pvc-filled pvc

Here's a screenshot from inkscape for better visibility :)

image

WDYT?

Looks good to me (the second one)! The first one to me looks like a fancy cake since it has the black outline / white dotted inside.

from podman-desktop.

deboer-tim avatar deboer-tim commented on June 21, 2024

Looks good to me (the second one)! The first one to me looks like a fancy cake since it has the black outline / white dotted inside.

LGTM, but I was assuming the first is 'solid' and the second is 'outline'? We do need both versions for nav/status icons.

from podman-desktop.

cdrage avatar cdrage commented on June 21, 2024

Ahh, that makes sense with regards to colouring. For some reason I thought it was 2 different versions for the navbar. I'm good with that, as I'm assuming the "cake" looking one will be coloured green, yellow, etc.

from podman-desktop.

deboer-tim avatar deboer-tim commented on June 21, 2024

Here's what it'll look like in context, I will PR as soon as #7640 gets merged:

Screenshot 2024-06-17 at 4 09 02 PM

I almost want to say the dashing could be a little more pronounced - but honestly it is great as-is.

And actually @ekidneyrh , would you mind redoing the regular solid volume icon with the 'outline' like above? The solid PVC stands out so much nicer I think we should do it here too:

Screenshot 2024-06-17 at 4 15 33 PM

from podman-desktop.

ekidneyrh avatar ekidneyrh commented on June 21, 2024

Lol yah it's for the solid one! It was tricky to have the dashes still visible but also have it filled in. I can do that :) I'll add onto this ticket

from podman-desktop.

ekidneyrh avatar ekidneyrh commented on June 21, 2024

SVG:
volume-filled

Preview from inkscape:
image

from podman-desktop.

deboer-tim avatar deboer-tim commented on June 21, 2024

Thanks! I do like this better and will PR at the same time as PVC.

Screenshot 2024-06-18 at 7 58 35 AM

from podman-desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.