GithubHelp home page GithubHelp logo

PEP8 style guide about podman-py HOT 3 CLOSED

containers avatar containers commented on June 9, 2024
PEP8 style guide

from podman-py.

Comments (3)

jwhonce avatar jwhonce commented on June 9, 2024

@danvergara I agree on setting a style. I've been using the black formatter to enforce style. It's a slight delta from PEP8 but not in a bad way. For example, 100 line length vs. 80 (we're no longer using vt100's or IBM cards); enforcing double quotes over single quotes, unless embedded. The best part of black is that it does not change the AST of your code, unlike tools like isort so it's safe to include in automation tool chains.

/cc @mwhahaha @baude

If we're in agreement on this tool, I'll update the CONTRIBUTING.md to reflect this choice. I will also check with our automation guys to see if we could run black on each PR before running the tests.

/cc @cevich @TomSweeneyRedHat

from podman-py.

mwhahaha avatar mwhahaha commented on June 9, 2024

We can also add black to pre-commit or via tox. It'd also be good to ensure we have consistent black configs. Over in OpenStack, black hasn't really picked up any traction so I'm used to the more strict pep8 rules but I think it'd be a good idea to automate it via black.

from podman-py.

cevich avatar cevich commented on June 9, 2024

see if we could run black on each PR before running the tests.

I'm assuming you mean on this repo? There is a a very basic .cirrus.yml here already. Maybe stick the call to the black check above this line?

from podman-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.