unable to open install tool with incomplete localconfig.php about installation-bundle

[fritzmg]

This is because InstallationKernel::boot executes InstallationKernel::bootRealSystem once a localconfig.php is present and this in turn initializes the Contao framework:

$container->get('contao.framework')->initialize();

which in turn calls ContaoFramework::validateInstallation at some point, which throws this error.

[leofeyer]

What do you mean by "incomplete localconfig.php"?

[fritzmg]

What do you mean by "incomplete localconfig.php"?

e.g. with either of these contents:

<?php

<?php

### INSTALL SCRIPT START ###
$GLOBALS['TL_CONFIG']['licenseAccepted'] = false;
### INSTALL SCRIPT STOP ###

<?php

### INSTALL SCRIPT START ###
$GLOBALS['TL_CONFIG']['licenseAccepted'] = false;
$GLOBALS['TL_CONFIG']['installPassword'] = '…';
### INSTALL SCRIPT STOP ###

<?php

### INSTALL SCRIPT START ###
$GLOBALS['TL_CONFIG']['installPassword'] = '…';
### INSTALL SCRIPT STOP ###

[leofeyer]

True, because that is actually how we check if the installation is complete:

https://github.com/contao/core-bundle/blob/master/src/Resources/contao/library/Contao/Config.php#L316

[fritzmg]

Yep I know. This is probably a benign issue, since there is not a valid reason to have a localconfig.php present with any of the content described above.

However, conceivably some user might think it's ok to delete the content of the localconfig.php, if he wants to reset his install tool password for instance, instead of just removing the respective entry - then it might be confusing to him what to do.

[leofeyer]

some user might think it's ok to delete the content of the localconfig.php, if he wants to reset his install tool password for instance

They might think so, but they are still wrong. If you remove the entire local configuration, your installation is in fact no longer complete. Therefore it is correct to throw the exception in this case.

[fritzmg]

Yes, but the exception tells you to open the install tool, which is where the exception occurs.

[leofeyer]

Fixed in contao/core-bundle@6bb407c.