Comments (2)
I think specifying Hashie < 3.0.0 has bad side, that garage gem restricts users to use Hashie 3.0.0 above.
The one of alternatives is not checking the value
responds to represent!
but checking the value
includes Garage::Representer
. Because the value
must respond to params=
and partial=
and more, checking againt represent!
is not enought.
I think alternative plan is reasonable. How do you think?
from garage.
We are facing this issue in our garage app, where hashie 3.4.3 is used.
The one of alternatives is not checking the value responds to represent! but checking the value includes Garage::Representer. Because the value must respond to params= and partial= and more, checking againt represent! is not enought.
This sounds good to me -- we are monkey patching as such and going to test with our app.
cc/ @creasty
from garage.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from garage.