GithubHelp home page GithubHelp logo

Broken with Hashie >= 3.0.0 about garage HOT 2 CLOSED

KOBA789 avatar KOBA789 commented on August 10, 2024
Broken with Hashie >= 3.0.0

from garage.

Comments (2)

taiki45 avatar taiki45 commented on August 10, 2024

I think specifying Hashie < 3.0.0 has bad side, that garage gem restricts users to use Hashie 3.0.0 above.

The one of alternatives is not checking the value responds to represent! but checking the value includes Garage::Representer. Because the value must respond to params= and partial= and more, checking againt represent! is not enought.

I think alternative plan is reasonable. How do you think?

from garage.

luvtechno avatar luvtechno commented on August 10, 2024

We are facing this issue in our garage app, where hashie 3.4.3 is used.

The one of alternatives is not checking the value responds to represent! but checking the value includes Garage::Representer. Because the value must respond to params= and partial= and more, checking againt represent! is not enought.

This sounds good to me -- we are monkey patching as such and going to test with our app.

cc/ @creasty

from garage.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.