Comments (9)
Yes, we need some sort of refactoring..
from coova-chilli.
I've come to love the development-mantra that NASA follows, according to Lifehacker:
http://lifehacker.com/nasas-rules-for-writing-mission-critical-code-1719276064
Might be overkill for coova-chilli, although readability and function-understanding would become a lot less vague.
With regards to testingtools, there's a few simple tools that can be utilized, and SHOULD be utilized as well (Valgrind, Helgrind), and possibly also an offsite analyzer like https://scan.coverity.com/ to catch possible memoryleaks/incorrect declarations and the likes.
from coova-chilli.
For the most part, emacs "mode: c; c-basic-offset: 2" is used throughout. (a recent commit fixed formatting in a couple places). Agreed, we should be more script on coding style and start to integrate testing into the build process.
from coova-chilli.
Do not forget to add modelines for VIM user like me ;)
from coova-chilli.
Perhaps we could use indent(1) or clang-format which could tie in as a hook so it would be irrelevant what editor you're using?
from coova-chilli.
π
from coova-chilli.
what about indent:
indent -nbad -bap -nbc -bbo -hnl -br -brs -c33 -cd33 -ncdb -ce -ci4 -cli0 -d0 -di1 -nfc1 -i2 -ip0 -l80 -lp -npcs -nprs -npsl -sai -saf -saw -ncs -nsc -sob -nfca -cp33 -ss -ts2 -il1 -nut
from coova-chilli.
most of those are gnu specific and not available everywhere, like hnl bbo nprs sai saf saw ncs
I stopped trying after that
from coova-chilli.
As I see it, we've two options here:
- Create CODINGSTYLE.md based on @wlanmac preferences (2 spaces indent level) and modify some existing CodingStyle to have some solid source for the remaining stuff like braces, long lines, variable namings etc. Then create some supporting scripts which would help reformat our code base, add Git commit hook script and some automatic Travis checking for PRs.
- Steal^Wborrow some existing CODINGSTYLE.md with all supporting scripts and checks to not reinvent the wheel, then reformat complete codebase with those script and start using it.
@wlanmac is probably the one to make this tough decision :)
from coova-chilli.
Related Issues (20)
- no snat rule in the up.sh and down.sh HOT 5
- Push routes to clients? HOT 4
- XT_COOVA not "called"? HOT 3
- Is the coova project dead? HOT 6
- Help with iptables and XT_COOVA HOT 1
- Π‘annot authorize the user by sessionid HOT 3
- compatibility with PHP 8.1 HOT 7
- How to open Splash page in Default Browser Automatically HOT 1
- XT-coova "screwing up" all "readings" - iptables in particular HOT 1
- cmdline.ggo HOT 1
- Coovachilli json wispr-bandwidth-max-down
- Will the next version be released? HOT 1
- Error relocating /lib//libchilli.so.0: __fxstat: symbol not found HOT 2
- tun/tap can't pass TCP/ICMP packet with xt_coova after authentication
- Set chilli wan to other not default wan interface HOT 1
- open all port
- Is Coova still working on Ubuntu? HOT 1
- Poor upload speed on ESXi HOT 11
- It doesnt work ChilliController.js
- Is there any way to use a black list instead of a walled garden?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coova-chilli.