simExtROS2 on ROS2 Galactic about simros2

[fferri]

I can create a PR.

Yes, please create a PR, so people can test your changes more easily.

Thanks

[fferri]

Supported ROS2 versions are listed in the README.md. Primary target is LTS releases. If you want to add support for latest ROS2 releases, PRs are welcome.

this does not seem like a well written cpp file

Can you elaborate on that? Looks fine to me.

[ccpjboss]

Oh sorry though it also supported ROS2 Galactic.
I'm sorry, and thanks for the fast answer.

[ccpjboss]

Hello again!

Related to this issue, I managed to solve the compilation errors for ROS2 Galactic, and now have a working version of simExtROS2 for ROS2 Galactic.

Are you interested in releasing these changes? I can create a PR.

[MathiasThor]

I'm facing the same issue - could you provide the solution to me? :)

[ccpjboss]

Sure! These were the changes I made:

• Change templates/cli_call.cpp line 12 from rclcpp::executor::FutureReturnCode::SUCCESS to rclcpp::FutureReturnCode::SUCCESS
• Change templates/actli_sendGoal.cpp line 47 from out->success = rclcpp::spin_until_future_complete(node, goal_handle_future) == rclcpp::executor::FutureReturnCode::SUCCESS; to out->success = rclcpp::spin_until_future_complete(node, goal_handle_future) == rclcpp::FutureReturnCode::SUCCESS;

Let me know if it worked!

[MathiasThor]

Thanks a lot for the quick response!

[ccpjboss]

Related PR #11