GithubHelp home page GithubHelp logo

Comments (6)

sekur avatar sekur commented on June 30, 2024

Can you expand on this scenario?

When we encounter the first missing include, the dynamic import resolver will attempt to find and internally load the dependent submodule with compile flag set to false. Each encounter of a missing include should try to do the same. Once all include dependencies have been internally loaded, then the compile should kick in for the main module which will perform necessary resolve for all included statements as a whole.

from yang-js.

sekur avatar sekur commented on June 30, 2024

Hmm, is this the case when there are nested submodule includes where a submodule also includes additional submodule(s)?

from yang-js.

sindhukothe avatar sindhukothe commented on June 30, 2024

I think you are right. I will have to dig the exact test case again, but meanwhile,
Here is the code change that worked. (I changed the compiled code as I am not very familiar with coffee script)
in yang.js
Replace This:
if (e.context.kind === 'include') {
opts.compile = false;
}
dependency = this["import"](this.resolve(basedir, e.context.tag), opts);

With.... (Not a very clean code, but just for experimentation only :) )
var newOpts = opts
if (e.context.kind === 'include') {
newOpts = {}
for (prop in opts) {
newOpts[prop] = opts[prop]
}
newOpts.compile = false
}
dependency = this["import"](this.resolve(basedir, e.context.tag), newOpts);

from yang-js.

sekur avatar sekur commented on June 30, 2024

Got it, that makes sense. Handling include overrides the shared opts object which then negates the compile value to false for the original module import. I'll make the necessary fix in coffeescript source.

from yang-js.

sekur avatar sekur commented on June 30, 2024

I used Object.assign for this scenario, let me know if this works

from yang-js.

sekur avatar sekur commented on June 30, 2024

Closing

from yang-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.