aws: kola iam role can get into weird state if user doesn't have passrole perms about mantle

[arithx]

At a minimum I think we need to make it clean up the resources if it experiences an error during initial creation. Probably also worth looking into if we can do a one-time per run check that the instance profile contains the role as with how it's currently laid out I think we'd end up checking once per cluster if not once per machine.

[dustymabe]

After I added passrole to my user and deleted the existing kola role I got a successful test:

$ kola -p aws --aws-ami ami-0e884738127697eb9 --aws-region us-east-1 -b fcos run coreos.ignition.resource.s3
=== RUN   coreos.ignition.resource.s3
--- PASS: coreos.ignition.resource.s3 (85.21s)
PASS, output in _kola_temp/aws-2019-08-21-1937-351

[cgwalters]

This is "kola prep isn't idempotent" right?

[dustymabe]

I think it tries to be but is missing a step. It checks for the role but I don't think it checks the instance profile to make sure it contains the role.

[arithx]

@cgwalters the code currently checks if the InstanceProfile exists, if it does it immediately exits without checking the underlying roles, if it doesn't it attempts to create said underlying roles. This ended up leading to this failure case where the creation of the underlying roles failed but the Instance Profile existed.