GithubHelp home page GithubHelp logo

Comments (7)

yoroto avatar yoroto commented on July 19, 2024 1

This is a known issue we discovered. The root cause is in the Java code of fxpackager which did not handle Microsoft's VC runtime name change (from msvcr??.dll to vcruntime??.dll) very well. We will provide fix in the next release.

from corretto-8.

yoroto avatar yoroto commented on July 19, 2024 1

Hi @DavidWich

We have fixed the issue in the release of 8u202.2 today. Please get it from our download page and check whether it fixed your issue. Please let us know if it is still a problem. Thanks!

from corretto-8.

davecurrie avatar davecurrie commented on July 19, 2024

@DavidWich Thanks for bringing this to our attention. We'll take a look at it asap.

from corretto-8.

DavidWich avatar DavidWich commented on July 19, 2024

Thank you for your fast effort to fix our issue. I will test it on Monday when I have access to my stuff.

from corretto-8.

DavidWich avatar DavidWich commented on July 19, 2024

The new version has fixed our issue regarding the Javapackager.

I appreciate your fast effort to fix our bug.

from corretto-8.

Maxoudela avatar Maxoudela commented on July 19, 2024

I don't know if this is related but I'm currently testing Corretto and building a JavaFX application.
the "vcruntime100.dll" is indeed located next to the Main.exe so I confirm the fix. However you said:

Microsoft's VC runtime name change (from msvcr??.dll to vcruntime??.dll)

If you look into the bin folder of Corretto, you can find the msvcr100.dll file that is still present.
If you look at the original issue in OpenJDK (https://bugs.openjdk.java.net/browse/JDK-8191176) you can see that their fix was to include msvcr files.

The backport for 8u172 is here https://bugs.openjdk.java.net/browse/JDK-8193482 and the codechange is
p -> Pattern.matches("^(vcruntime|msvcp|msvcr|ucrtbase|api-ms-win-).*\\.dll$", p.toFile().getName().toLowerCase()))

Therefore, my guess is that the msvcr100.dll file should also be located next to the Main.exe. I have an example in Windows 10 without VS studio installed where the bundle generated by Corretto cannot be launched because this file is missing.

from corretto-8.

pablozoani avatar pablozoani commented on July 19, 2024

Hi,

This issue is happening again with the following java version:

openjdk version "1.8.0_392"
OpenJDK Runtime Environment Corretto-8.392.08.1 (build 1.8.0_392-b08)
OpenJDK 64-Bit Server VM Corretto-8.392.08.1 (build 25.392-b08, mixed mode)

We were working with jdk1.8.0_342 and everything was going ok.

vcruntime140.dll and msvcp140.dll are properly copied to the output folder, bundle/runtime/bin.

Even more, regardless the error "Bundler Windows Application Image failed because of java.lang.RuntimeException: Not found MSVC dlls", our application seems to be running without issues.

javapackager ^
	-deploy ^
	-native image ^
		-BinstalldirChooser=true ^
		-Bwin.menuGroup="..." ^
		-BshortcutHint=true ^
		-BappVersion=240116 ^
		-BjvmOptions=-Xverify:none ^
		-Bclasspath="..." ^
		-BmainJar="..." ^
		-Bicon=.\images\icon.ico ^
	-appclass ... ^
	-verbose ^
	-vendor "..." ^
	-outdir "..." ^
	-outfile "..." ^
	-srcdir ... ^
	-title ... ^
	-name ...

It seems that the code is not handling the name change again vcruntime???.dll and msvcp???.dll.

Thank you very much

from corretto-8.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.