GithubHelp home page GithubHelp logo

Comments (18)

bkbartk avatar bkbartk commented on August 17, 2024 1

Thank you that is really fast,
I did some tests and everything seems to work perfect.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

I believe this is indeed more of an RGB/RGBWW issue than a LibreTiny issue. I know everything compiles fine, but I have also noticed a similar issue with bulbs running LibreTiny where the RGB portions work correctly, but the white channels fail to update, and rebooting seems to be the only solution. The logs show the bulbs receiving the message, but they just don't actually update. I'll look into this as time permits.

Can you clarify if the bulbs you are experiencing this with are PWM or have a specific LED driver?

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

I think it's PWM, but I'm not sure.
my config is like this

esphome:
  name: ${device_name}
  friendly_name: ${device_name}

bk72xx:
  # framework:
  #   version: dev  #for dev now
  board: generic-bk7231t-qfn32-tuya

text_sensor:
  - platform: libretiny
    version:
      name: LibreTiny Version

output:
  - platform: libretiny_pwm #ledc
    id: output_red
    pin: P26
  - platform: libretiny_pwm #ledc
    id: output_green
    pin: P6
  - platform: libretiny_pwm #ledc
    id: output_blue
    pin: P24
  - platform: libretiny_pwm #ledc
    id: output_cold
    pin: P8
  - platform: libretiny_pwm #ledc
    id: output_warm
    pin: P7

light:
  - platform: rgbww
    restore_mode: RESTORE_DEFAULT_ON
    id: light_rgbww
    name: ${switch_name}
    color_interlock: true
    cold_white_color_temperature: 6500 K
    warm_white_color_temperature: 2700 K
    red: output_red
    green: output_green
    blue: output_blue
    cold_white: output_cold
    warm_white: output_warm

(on libretiny 1.2 I used ledc)

the strange thing is that for me the issue occurs when the bulb is the sending device, not the receiving one.

  • on one side I have the bulb, and on the other side just a simple swich.
# external_components:
#     - source: github://cossid/tasmotadevicegroupsforesphome@main
#       components: [ device_groups ]
#       refresh: 10 min

# device_groups:
#   - group_name: "bulbkamervoor"     # Tasmota device group name
#     lights:
#       - light_rgbww
# external_components:
#     - source: github://cossid/tasmotadevicegroupsforesphome@main
#       components: [ device_groups ]
#       refresh: 10 min

# device_groups:
#   - group_name: "bulbkamerachter"     # Tasmota device group name
#     switches:
#       - dummy_bulb_achter
#   - group_name: "bulbkamervoor"     # Tasmota device group name
#     switches:
#       - dummy_bulb_voor

but the issue occurs when chaning the light temperature a couple of times in home assistant.

and when disabling the component the issue is gone.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

Yep, that is PWM, thanks for confirming, that helps me rule out LED driver issues (I was only testing on bulbs with LED drivers so far). It appears each time a white channel is set via device groups, it halves the values of the white channels each time until they are too dim to display. I'll see if I can find the cause of this.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

I've pushed a change that should fix this. White channels were coming back with the brightness applied each time, so it would just keep going lower and lower until they remained off. I've switched to getting the white channels and brightness directly instead.

Let me know if this doesn't fix it for you.

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

is this issue back somehow?
the only thing changed I see is
a59e46d
but for somehow I can't get the files edited local, So I cannot test if reversing this works,
I need to check my local issue too.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

No, it shouldn't be back that I'm aware of, but there are other bugs in RGBCT mode (different from RGBWW). I'm still working on that, but haven't gotten everything fixed yet.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

I take that back, it might have been re-introduced. Not sure why as_x() would return such different results from get_x() on the same values. Looking into it.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

Commited a combo fix of what I was working on with rgbct (still has a but I don't have fully ironed out yet that can cause watchdog reboots), which goes back to get_x() instead of as_x(), as that change was also attempting to fix rgbct, but failed.

Let me know if that is/isn't working.

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

Thnx. That helps.

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

Sorry to bother you again,
but I found something else,
adjusting the color decreases the brightness. But now the brightness is acurate, so I can increase it again in brightness without restarting the device.
I recorded some logging, not sure if this is helpful.

21:11:55	[D]	[dgr:621]	Sending bulbkamervoor message to network: seq=165, flags=0, 5=74
21:11:55	[W]	[component:204]	Component device_groups took a long time for an operation (0.07 s).
21:11:55	[W]	[component:205]	Components should block for at most 20-30ms.
21:11:55	[D]	[light:036]	'Bulb Kamer voor' Setting:
21:11:55	[D]	[light:058]	  Red: 100%, Green: 100%, Blue: 100%
21:11:56	[D]	[light:085]	  Transition length: 1.0s
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=164, flags=16, 224=255,255,255,0,0,0*
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=165, flags=8
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=165, flags=8
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=165, flags=8
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.247: seq=165, flags=8
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.247: seq=165, flags=8
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.110: seq=165, flags=8
21:11:56	[D]	[light:036]	'Bulb Kamer voor' Setting:
21:11:56	[D]	[light:051]	  Brightness: 8%
21:11:56	[D]	[light:055]	  Color brightness: 100%
21:11:56	[D]	[light:058]	  Red: 100%, Green: 100%, Blue: 100%
21:11:56	[D]	[light:085]	  Transition length: 1.0s
21:11:56	[D]	[dgr:621]	Sending bulbkamervoor message to network: seq=166, flags=16, 128=335544321
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from local: seq=166, flags=16, 128=335544321*
21:11:56	[D]	[dgr:621]	Sending bulbkamervoor message to network: seq=167, flags=16, 224=255,255,255,0,0,0
21:11:56	[D]	[light:036]	'Bulb Kamer voor' Setting:
21:11:56	[D]	[light:058]	  Red: 100%, Green: 100%, Blue: 100%
21:11:56	[D]	[light:085]	  Transition length: 1.0s
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from local: seq=167, flags=16, 224=255,255,255,0,0,0*
21:11:56	[D]	[dgr:621]	Sending bulbkamervoor message to network: seq=168, flags=0, 5=20
21:11:56	[I]	[light:392]	'Bulb Kamer voor' - Keeping current color mode RGB for call without color mode.
21:11:56	[D]	[light:036]	'Bulb Kamer voor' Setting:
21:11:56	[D]	[light:051]	  Brightness: 8%
21:11:56	[D]	[light:055]	  Color brightness: 8%
21:11:56	[D]	[light:085]	  Transition length: 1.0s
21:11:56	[D]	[dgr:621]	Received bulbkamervoor message from local: seq=168, flags=0, 5=20*
21:11:57	[W]	[component:204]	Component api took a long time for an operation (0.11 s).
21:11:57	[D]	[dgr:621]	Sending bulbkamervoor message to 192.168.180.173: seq=168, flags=8
21:11:57	[I]	[light:392]	'Bulb Kamer voor' - Keeping current color mode RGB for call without color mode.
21:11:57	[D]	[light:036]	'Bulb Kamer voor' Setting:
21:11:57	[D]	[light:051]	  Brightness: 8%
21:11:57	[D]	[light:055]	  Color brightness: 8%
21:11:57	[D]	[light:085]	  Transition length: 1.0s
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=168, flags=0, 5=20*
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.247: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.247: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.247: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Sending bulbkamervoor message to network: seq=168, flags=0, 5=20
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.247: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Sending bulbkamervoor message to 192.168.180.173: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=168, flags=0 (old)
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.173: seq=168, flags=8
21:11:57	[D]	[dgr:621]	Received bulbkamervoor message from 192.168.180.110: seq=168, flags=8

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

You're going to have to give a more descriptive reproduction case and explanation, as I'm not seeing what you are seeing.

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

[vedio removed because it showed my HA url]

I hope github will accept my video,
I tried to screen record my home assistant.
I have 3 devices in this group in total
2 switches
1 RGBWW bulb.

When pushing 1 of the switches, the bulb should toggle on/off and it does.

But when adjusting to color in Home Assistant, the brightness also changes, I tried removing this component from the config and then the issue was gone, So at that point a narrowed it down to this component.

I'm wondering if I could test something else
if I set the brightness to 100% the issue doesn't exists.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

This might be a bug in home assistant? If you change colors with the pre-selected at the bottom, it does not do this, regardless of what your brightness % is at. It appears to me HA is the one sending the alternate brightness.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

Strange, the issue does go away if removing device groups, but I can't explain why it is happening with device groups.

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

I know,
just tested it again, and on one of my devices which I haven't updated recently the issue doesn't exists.
I'm not sure but I think it's this commit.
a59e46d

unfortunately esphome moved the .esphome folder so I cannot modify the files locally to check.
And really strang that the issue doesn't exists on for the buttons on the bottom, or maybe at that point HA also sends the brightness, where as for the color selecter HA only sends the color? just guessing here.

[edit]:
v1.4.0 on generic-bk7231n-qfn32-tuya, compiled at Sep 16 2023 23:09:50, GCC 10.3.1 (-O1)
from the device without issues, so the issue was introduced after september 16th.

from tasmotadevicegroupsforesphome.

Cossid avatar Cossid commented on August 17, 2024

I removed the set_color_brightness along side the usual set_brightness, and that seems to have resolved it. No idea why, as they should have been set to the same values.

Update and it should be working.

from tasmotadevicegroupsforesphome.

bkbartk avatar bkbartk commented on August 17, 2024

thanks again, it works,

what I'm wondering about now is the inconsistency within home assistant.

from tasmotadevicegroupsforesphome.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.