GithubHelp home page GithubHelp logo

Comments (4)

cf19drofxots avatar cf19drofxots commented on August 12, 2024

That's correct - it's now expected-build-artifacts and the node code references this new path.

Given this, can you point out what the remaining issue is?

from monorepo.

rhlsthrm avatar rhlsthrm commented on August 12, 2024

In a blank project, I installed both contracts packages from NPM. The versions that installed were:

@counterfactual/[email protected]
@counterfactual/[email protected]

When I inspect both packages in the node_modules directory, I see the following:

$ ls cf-adjudicator-contracts/                                                                                                                    
LICENSE      README.md    build        contracts    networks     package.json
$ ls cf-funding-protocol-contracts/                                                                                                               
LICENSE      README.md    contracts    networks     package.json

As you can see, cf-adjudicator-contracts contains the expected build directory, but cf-funding-protocol-contracts does not. This leads me to believe there is a specific issue with the latest publish of that package. Also, the expected-build-artifacts directory is present in the source code, but not in the published package on NPM.

from monorepo.

cf19drofxots avatar cf19drofxots commented on August 12, 2024

@rhlsthrm can you try again with the updated versions?

from monorepo.

rhlsthrm avatar rhlsthrm commented on August 12, 2024

Cool looks like that fixed the issue! Thanks @cf19drofxots

from monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.