Delta Configuration Not Matching Current Marlin 2.0.x[Bug] about octoprint-eeprom-marlin

[Firworksyt]

I'll see if I can find the thread on the Marlin Github but they've mentioned that documentation is out of date and haven't gotten around to updating it still.

[Firworksyt]

Sure, I'll clean it up some and test it out a bit more and then attach it here. I made the initial edit to see if I could figure it out and then came here when it worked.

I looked at the current Marlin source and here's where they're declaring the data structure to store delta configurations:

https://github.com/MarlinFirmware/Marlin/blob/f74015b4e57677cd033e116dab2331478edbe2ec/Marlin/src/module/settings.cpp#L266-L282

Here's where they're parsing a received M665 message:

https://github.com/MarlinFirmware/Marlin/blob/f74015b4e57677cd033e116dab2331478edbe2ec/Marlin/src/gcode/calibrate/M665.cpp#L30-L59

Here's where they're sending out a M665 as part of the settings report in response to something like an M503:

https://github.com/MarlinFirmware/Marlin/blob/f74015b4e57677cd033e116dab2331478edbe2ec/Marlin/src/module/settings.cpp#L3207-L3230

All of them show this format with ABC for rod length so I think the documentation is just wrong.

One question I had while looking at these though is how you want to handle SCARA printers. I know they're even less common than Deltas but it looks like Marlin has overlaid the M665 message to either be a Delta config or SCARA config. If someone with a SCARA printer tries the plugin it'll probably behave very strangely. The start of the M665 response does say either "SCARA settings:" or "Delta settings:" so you could probably key off of that.

[cp2004]

So I'm reading the documentation for marlin (https://marlinfw.org/docs/gcode/M665.html) about this code, and it lists the B parameter as the calibration radius. As far as I can tell, the plugin should be using this B parameter in this field. Could you explain a little more about which parameter you expected to be under 'Calibration radius' label?

I don't have a delta machine, so have to go from the docs to create the plugin, or by someone else telling me otherwise. Might be able to read the source of the command, or ask in the Marlin discord to see if they know more info about the docs being different.

[cp2004]

@Firworksyt You mentioned you adjusted the plugin to work for you, if you can upload the files here I would be able to add them (with you as the co-author). I'll also ask on the Marlin discord at some point, unless maybe reading the source would be easier 😄.

[cp2004]

Yeah, SCARA is not handled at all. Could probably be done, with a flag in it's data entry. That's not actually something I decided on, since I adopted this plugin back in October. Of course, with V3 I re-wrote most of it but the concept of what commands etc. was still there from the old version. Now I've got it into a decent framework, we can think about things like this. Interestingly, in the 5 years this plugin has been around, no one has mentioned SCARA support in a single issue, out of over 5K tracked installs. I'll see, if it is simple enough to set a flag (based on the response you mention) to change things, otherwise it is very low priority.

Thanks for the links, saves me some time clicking and trying to comprehend the Marlin structure for a while 🙂.

[cp2004]

Alright, I think I got this one. I'll let you know when there's a pre-release available to test, since I don't have a delta I hope I've read all the sources you posted correctly.

[cp2004]

There's a release candidate available for you to test this now: 3.1.0rc1. Feedback ticket #45 for any comments on the release. Stable release approx. 1 week depending on how the testing goes.