Comments (9)
Would you mind doing a quick test to see if it does round it when sent to the printer? It's using a generic template, I guess we need more conditional work here. Problem is, in Marlin there's no consistency and I always end up with really specific cases, when I was trying to make generic definitions....
Anyway, I will see about fixing it for 3.1.0, I think there's probably something else like that around too.
from octoprint-eeprom-marlin.
Everything's printing right now, so I can't test, but a simple change to a checkbox (☑ signifying a "1" when stored) or Radio Button set ( ʘ Enabled O Disabled ), to me, would be far simpler than trying to specific-case conditionals.
from octoprint-eeprom-marlin.
OK, fired up the spare Pi and OP. Anything ≥ 1 when stored, displays as "1" when reloaded [although there's no telling what value is in the background). Anything < 1, when stored, displays as "0" - again, no telling whether it's floating point or integer in the background.
from octoprint-eeprom-marlin.
Thank you - that confirms that it's not really a critical bug that breaks everything when decimals 😄.
I agree, a checkbox would be easier on the user - but it makes it harder to send to the firmware, and further away from the command itself for those used to them. I will likely just lock it to 1/0 if possible, unless I can think of a smart way to do the checkbox.
from octoprint-eeprom-marlin.
I think that the average person who uses this kind of thing doesn't necessarily care about being "further away from the command itself" - they are just looking for functionality. Also, the average non-technical/coder user doesn't really inherently know that 1==enabled/0==disabled in most things.
I'm also having a hard time figuring out why it would be so hard to use a boolean (checkbox/radio button enabled) to represent an already boolean value (bed level enabled/disabled). I admit it's been a long time since I coded, but a simple if/then test should do it.
from octoprint-eeprom-marlin.
Yeah it is not difficult per se, it just requires extra steps in what is currently a very streamlined process, to convert something: true
into S1
or something like that, and it requires this on all the ends where it comes in and out of the UI.
from octoprint-eeprom-marlin.
OK following a nearly two month break from this plugin... I've done this one.
The latest commits in this repository have switched the entire codebase over to a single source of truth, that makes maintainability easier with definitions for all the commands. This means I have been able to support Boolean values through this quite easily, so they are now checkboxes. So it's ready for 3.1.0 🙂
from octoprint-eeprom-marlin.
There's a release candidate available for testing this now: 3.1.0rc1. Feedback ticket #45 for any comments on the release. Stable release approx. 1 week depending on how the testing goes.
from octoprint-eeprom-marlin.
3.1.0 has been released
from octoprint-eeprom-marlin.
Related Issues (20)
- [Feedback] Marlin EEPROM Editor 3.2.0rc Feedback HOT 2
- CR-10 Smart printer isn't recognized as Marlin firmware HOT 5
- IMPORTANT: The next release of this plugin will not support Python 2
- Upgrade pre-commit and add pyupgrade HOT 1
- [Request]: Automatic scheduled EEPROM backups HOT 3
- Retrieve and Set Stealthchop for TMC Drivers[Request]: HOT 4
- [Bug]: PluginManager typo -> link to gihtub HOT 4
- [Request]: Only FIRMWARE INFO in the left column HOT 14
- [Bug]: Doesn't work with Snapmaker 2.0 A350 HOT 3
- [Request]: When enabled in Firmware, Add M306 data to Temperature tab HOT 7
- [Bug]: E0 stepper current not saved HOT 3
- Please add MPC to the menu HOT 2
- [Request]: Add LONG_FILENAME_WRITE_SUPPORT HOT 2
- [Bug]: After Marlin Update, ignore crc mismatch, restoring a config M112 ERROR when no bed mesh is stored HOT 2
- [Request]: Add M914 TMC Bump Sensitivity HOT 1
- [Request]: Add M423 support HOT 1
- [Request]: Using eprom locked on iPad HOT 6
- [Request]: Separate X and Y values for Input Shaping HOT 1
- Support- Willing to pay for your time HOT 1
- [Request]: Unkown Command M207 x8/x20 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octoprint-eeprom-marlin.