Comments (9)
Thanks for reporting. Just a note that I’ve seen this. I’ll take a look when I have time to work on this again.
from xcbeautify.
Hi @thii! Are you still looking for help with this? Are there any plans (how) to implement this?
I'd like to help where I can to get this merged, so I'd appreciate some context on the state of this request.
from xcbeautify.
I've created this draft PR: #107.
I'd appreciate some initial reviews and guidance on how to iterate the proposed implementation.
I've tested it on my project; right now, I'm noticing some errors around duplicate compiler warning/error output and test formatting. I'm also seeing annotations related to 3P dependencies- not sure if that's helpful and/or desired.
from xcbeautify.
This looks really interesting but I'm not quite sure if I'm using this new renderer correctly. Is there an example somewhere what this would look like in a GH action with a test failure?
I've triggered an action with a failing test and the result looks like this:
This is what this same error looked like before this change:
Sure, the error is a bit more obvious but given the length of our logs (thousands of lines) this change isn't what I was hoping for.
I suspect the github-actions
format error report should be showing up elsewhere in the GH action UI but I can't see any difference between the two runs. Is perhaps something in our setup preventing this from properly propagating?
from xcbeautify.
@orj @cpisciotta @thii Apologies for the direct ping but you might not get notified for comments on closed issues. Would one of you have any guidance regarding my comment above?
from xcbeautify.
Hey @finestructure! Sorry for the delayed response! You'll find the annotations in the summary section of a GitHub Actions run.
In your case, it's here. Annotations that tie to a specific file and line number will show as an inline comment; in your case, there's an example here.
I've been meaning to publish better docs on this, and I will very soon! I've been working with Apple to resolve some issues that I found while doing this work, so some of it is still "under development." I'd also like to iterate on the format of the console logs, since it was a first pass at a very different format of the pre-existing renderer.
Let me know how else I can help, and please provide any feedback if you have any!
from xcbeautify.
Let me know if you're not seeing the annotations via those links. They seem to point to different examples than I wanted.
from xcbeautify.
Hey @finestructure! Sorry for the delayed response! You'll find the annotations in the summary section of a GitHub Actions run.
Oooh... I've been so used to click through this screen to get to the details that I don't even look at what's there anymore 🤦♂️😄
This is a great change, it'll make dealing with test features so much easier. Thank you! ❤️
from xcbeautify.
BTW, inside GH action runs GITHUB_WORKFLOW
is set. So this mode could even be the default and use the normal ANSI colour terminal mode if it isn't set and the annotations otherwise. Just a thought!
from xcbeautify.
Related Issues (20)
- [New Output] Support WriteAuxiliaryFile Output HOT 1
- [New Output] Support Note Output HOT 1
- [New Output] Improve Multiline Compiler Warning Output HOT 3
- [New Output] Support Copy Output HOT 1
- [New Output] Support SwiftCompile Output
- [New Output] Support SwiftDriver Compilation Target Output HOT 1
- [New Output] Support SwiftDriver Compilation Requirements Output HOT 1
- [New Output] Support Conflicting AutoLayout Constraints Output HOT 1
- [New Output] Support DVTAssertions Output HOT 1
- Upgrade to Swift 5.9 HOT 2
- Replace Public Access Modifiers with Package Access Modifiers
- Replace Renovate with Dependabot
- Treat Warnings as Errors
- Add Code Coverage Check
- Introduce a Configuration File
- Build Against Multiple Swift Versions
- Introduce ParserTests
- Resolve GHA Warnings in Release Workflow
- Add End-to-End Tests
- [New Output] Build Timing Summary HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xcbeautify.