GithubHelp home page GithubHelp logo

Comments (2)

friendlyanon avatar friendlyanon commented on July 19, 2024 1

I see, so this issue is outside the scope of CPM.cmake and can only be fixed on the dependency's side.

from cpm.cmake.

TheLartians avatar TheLartians commented on July 19, 2024

I agree that it would be a great to include directories from external dependencies as SYSTEM to avoid warnings that we have no control over. However afaik, I don't think CPM.cmake can do anything here, as the system keyword need to be used inside each library's CMakeLists.txt whenever using target_include_directories on the exported targets.

As this is usually undesirable for library maintainers, this leaves only the option of either ignoring the warnings around the bad #includes:

// save compiler switches
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wpedantic"

// bad headers with problem goes here
#include <library/with/warnings>

// restore compiler switches
#pragma GCC diagnostic pop

Or, of course, you could ask the library maintainer to fix the code that causes the warnings or you fix them in a fork yourself and share the fix in a PR to the main repo.

from cpm.cmake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.