GithubHelp home page GithubHelp logo

Comments (5)

ddalcino avatar ddalcino commented on July 29, 2024

There are two obvious ways to solve this (see discussion at cpp-best-practices/gui_starter_template#208):

  • bump the minimum CMake dependency to 3.18, or
  • bump the project_options version to 0.19.0+

From cpp-best-practices/gui_starter_template#208 (comment):

I think the larger issue here is that we should test the minimum required versions of our tools in CI, and keep these up-to-date in our documentation. Our README specifies that you can use clang 6 or gcc 7, or any compiler that supports C++17. This is no longer true, since the project requires C++20. Conceivably, you could manually set CMAKE_CXX_STANDARD to C++17 and expect the project to work, but since we aren't testing that, we don't know that it will work and we shouldn't tell our users that it will.

from cmake_conan_boilerplate_template.

lefticus avatar lefticus commented on July 29, 2024

@ddalcino very good point. I'll create a new branch that we can collaborate on to get the docs/dependencies in alignment, and test upgrading to project_options 0.20.0

We can also use that branch to discuss if we want our own fork of project_options.

from cmake_conan_boilerplate_template.

lefticus avatar lefticus commented on July 29, 2024

See #18

Looks like we have work to do. Seems conan is no longer running. Somehow was disabled in the dynamic_project_options defaults, perhaps?

from cmake_conan_boilerplate_template.

ddalcino avatar ddalcino commented on July 29, 2024

Looks like it happened here: aminya/project_options#71

Should be easy enough to specify ENABLE_CONAN when we call dynamic_project_options() though.

from cmake_conan_boilerplate_template.

lefticus avatar lefticus commented on July 29, 2024

Fixed in e51378d I think

from cmake_conan_boilerplate_template.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.