GithubHelp home page GithubHelp logo

Comments (7)

akoshodi avatar akoshodi commented on July 30, 2024 12

Found a temporary solution inspired by #402 (comment)
To get dnf to install the PHP modules the way Fedora expects i.e dnf install php-fpm , replace php{$this->version}-fpm with php-fpm in the install function in ~/.config/composer/vendor/cpriego/valet-linux/cli/Valet/PhpFpm.php as seen in the screenshot below

valet-fix

from valet-linux.

AhmedAnbar avatar AhmedAnbar commented on July 30, 2024

same here with php 7.4 installed fpm using dnf install php74-fpm

error

from valet-linux.

m-hazem avatar m-hazem commented on July 30, 2024

Faced same issue. I am using Fedora 37
i used @akoshodi workaround comment to make it works

from valet-linux.

faridsa avatar faridsa commented on July 30, 2024

@akoshodi fix works for me too, under Fedora 37.

from valet-linux.

mc0de avatar mc0de commented on July 30, 2024

Dnf installation was broken by assuming that ALL package managers are naming php-fpm packages in same way as apt, I assume the author didn't even test it on RedHat based distros 6e9b617

PhpFpm.php completely disregards Fedora's package naming, this file needs complete refactoring or "dirty" hacks.

6e9b617#diff-d8e7b9c98bc6a045292f784be0d98860c26b463a1dd29f36256fed1d2ad62752

install() method should check against package manager class in use instead of blatantly asking version by Ubuntu naming scheme.

6e9b617#diff-d8e7b9c98bc6a045292f784be0d98860c26b463a1dd29f36256fed1d2ad62752R414 also returns wrong socket name

/etc/php-fpm.d/valet.conf should have listen = /home/lun/.valet/valet.sock value instead of listen = /home/lun/.valet/valet82.sock, OR nginx configuration templates should be updated.

I'd suggest to not use anything above v2.2.36 for Fedora, as it is bricked and not tested.

composer require cpriego/valet-linux:2.2.36

from valet-linux.

akoshodi avatar akoshodi commented on July 30, 2024

I also posted about this in Valet Linux Plus, and the issue has now been been fixed there genesisweb/valet-linux-plus#69

from valet-linux.

mc0de avatar mc0de commented on July 30, 2024

I also posted about this in Valet Linux Plus, and the issue has now been been fixed there genesisweb/valet-linux-plus#69

well, this is not the actual fix. i've reviewed that earlier. that would break all other installation processes for other distros. more like "it works on my machine" hack.

from valet-linux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.