GithubHelp home page GithubHelp logo

Add segmentation evaluation about mir_eval HOT 6 CLOSED

craffel avatar craffel commented on August 26, 2024
Add segmentation evaluation

from mir_eval.

Comments (6)

bmcfee avatar bmcfee commented on August 26, 2024

General question: is it reasonable to add a scikit-learn dependency to this module? Some of the segmentation evals reduce to clustering evaluations already implemented by sklearn (after some boundary->frame conversion), and I'd really prefer to not implement that all over again.

from mir_eval.

craffel avatar craffel commented on August 26, 2024

I'd say definitely not, there are plenty of use cases for people who may not have sklearn. Someone else must have implemented this natively already right? Worst case you could wrap the import in a try catch statement (so all other modules would work) but that's nasty.

-Colin

On Aug 14, 2013, at 1:19 AM, Brian McFee [email protected] wrote:

General question: is it reasonable to add a scikit-learn dependency to this module? Some of the segmentation evals reduce to clustering evaluations already implemented by sklearn (after some boundary->frame conversion), and I'd really prefer to not implement that all over again.


Reply to this email directly or view it on GitHub.

from mir_eval.

craffel avatar craffel commented on August 26, 2024

Also-will scipy's clustering submodule do the trick instead?

-Colin

On Aug 14, 2013, at 1:19 AM, Brian McFee [email protected] wrote:

General question: is it reasonable to add a scikit-learn dependency to this module? Some of the segmentation evals reduce to clustering evaluations already implemented by sklearn (after some boundary->frame conversion), and I'd really prefer to not implement that all over again.


Reply to this email directly or view it on GitHub.

from mir_eval.

bmcfee avatar bmcfee commented on August 26, 2024

It looks like scipy.cluster just implements learning algorithms, not metrics, so no.

Re: sklearn dependency: are there really that many use cases? I'm hardly one for adding dependencies purely out of laziness, but it seems reasonable (to me) that the sort of user that would have need for a full-blown MIR eval package in python might also be the sort to want/use sklearn.

I could also see getting a lot more reuse out of sklearn.metrics beyond clustering (say, for annotation/retrieval evaluation, or maybe cv splits).

from mir_eval.

craffel avatar craffel commented on August 26, 2024

Yeah, I think while the use of ML in MIR is pretty widespread, there are still plenty of people working on eg onset, beat, chord recognition etc algorithms which are not learning based. I'd also think there's a substantial population of people using other ML tools instead. Not that installing sklearn should be a big deal for any of them. I just am uncomfortable with added dependencies which a large chunk of your user base may not have.

-Colin

On Aug 14, 2013, at 9:00 PM, Brian McFee [email protected] wrote:

It looks like scipy.cluster just implements learning algorithms, not metrics, so no.

Re: sklearn dependency: are there really that many use cases? I'm hardly one for adding dependencies purely out of laziness, but it seems reasonable (to me) that the sort of user that would have need for a full-blown MIR eval package in python might also be the sort to want/use sklearn.

I could also see getting a lot more reuse out of sklearn.metrics beyond clustering (say, for annotation/retrieval evaluation, or maybe cv splits).


Reply to this email directly or view it on GitHub.

from mir_eval.

craffel avatar craffel commented on August 26, 2024

All that being said if you think it'd be a big pain to reimplement feel free to add the sklearn dependency, it's not the end of the world.

-Colin

On Aug 14, 2013, at 9:00 PM, Brian McFee [email protected] wrote:

It looks like scipy.cluster just implements learning algorithms, not metrics, so no.

Re: sklearn dependency: are there really that many use cases? I'm hardly one for adding dependencies purely out of laziness, but it seems reasonable (to me) that the sort of user that would have need for a full-blown MIR eval package in python might also be the sort to want/use sklearn.

I could also see getting a lot more reuse out of sklearn.metrics beyond clustering (say, for annotation/retrieval evaluation, or maybe cv splits).


Reply to this email directly or view it on GitHub.

from mir_eval.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.