Comments (6)
General question: is it reasonable to add a scikit-learn dependency to this module? Some of the segmentation evals reduce to clustering evaluations already implemented by sklearn (after some boundary->frame conversion), and I'd really prefer to not implement that all over again.
from mir_eval.
I'd say definitely not, there are plenty of use cases for people who may not have sklearn. Someone else must have implemented this natively already right? Worst case you could wrap the import in a try catch statement (so all other modules would work) but that's nasty.
-Colin
On Aug 14, 2013, at 1:19 AM, Brian McFee [email protected] wrote:
General question: is it reasonable to add a scikit-learn dependency to this module? Some of the segmentation evals reduce to clustering evaluations already implemented by sklearn (after some boundary->frame conversion), and I'd really prefer to not implement that all over again.
—
Reply to this email directly or view it on GitHub.
from mir_eval.
Also-will scipy's clustering submodule do the trick instead?
-Colin
On Aug 14, 2013, at 1:19 AM, Brian McFee [email protected] wrote:
General question: is it reasonable to add a scikit-learn dependency to this module? Some of the segmentation evals reduce to clustering evaluations already implemented by sklearn (after some boundary->frame conversion), and I'd really prefer to not implement that all over again.
—
Reply to this email directly or view it on GitHub.
from mir_eval.
It looks like scipy.cluster just implements learning algorithms, not metrics, so no.
Re: sklearn dependency: are there really that many use cases? I'm hardly one for adding dependencies purely out of laziness, but it seems reasonable (to me) that the sort of user that would have need for a full-blown MIR eval package in python might also be the sort to want/use sklearn.
I could also see getting a lot more reuse out of sklearn.metrics beyond clustering (say, for annotation/retrieval evaluation, or maybe cv splits).
from mir_eval.
Yeah, I think while the use of ML in MIR is pretty widespread, there are still plenty of people working on eg onset, beat, chord recognition etc algorithms which are not learning based. I'd also think there's a substantial population of people using other ML tools instead. Not that installing sklearn should be a big deal for any of them. I just am uncomfortable with added dependencies which a large chunk of your user base may not have.
-Colin
On Aug 14, 2013, at 9:00 PM, Brian McFee [email protected] wrote:
It looks like scipy.cluster just implements learning algorithms, not metrics, so no.
Re: sklearn dependency: are there really that many use cases? I'm hardly one for adding dependencies purely out of laziness, but it seems reasonable (to me) that the sort of user that would have need for a full-blown MIR eval package in python might also be the sort to want/use sklearn.
I could also see getting a lot more reuse out of sklearn.metrics beyond clustering (say, for annotation/retrieval evaluation, or maybe cv splits).
—
Reply to this email directly or view it on GitHub.
from mir_eval.
All that being said if you think it'd be a big pain to reimplement feel free to add the sklearn dependency, it's not the end of the world.
-Colin
On Aug 14, 2013, at 9:00 PM, Brian McFee [email protected] wrote:
It looks like scipy.cluster just implements learning algorithms, not metrics, so no.
Re: sklearn dependency: are there really that many use cases? I'm hardly one for adding dependencies purely out of laziness, but it seems reasonable (to me) that the sort of user that would have need for a full-blown MIR eval package in python might also be the sort to want/use sklearn.
I could also see getting a lot more reuse out of sklearn.metrics beyond clustering (say, for annotation/retrieval evaluation, or maybe cv splits).
—
Reply to this email directly or view it on GitHub.
from mir_eval.
Related Issues (20)
- Evaluation of SDR and SIR HOT 2
- How to evaluate SIR and SDR for mono wav files HOT 1
- Are there any methods for transposing chord notations from one key to another? HOT 1
- Debian Package - Disable function /tests with construction errors HOT 7
- Test fails on 32 bit x86 HOT 2
- update numpy dependency HOT 7
- Migrate pull request automated testing from Travis CI to GitHub Actions HOT 2
- Rename default branch to `main` HOT 1
- Guidance on the right metric? HOT 3
- Support matplotlib 3.8 HOT 7
- Entropy Based Evaluation of unlabelled sections
- Release a patched version to PyPI for NumPy compatibility HOT 1
- Docs: multipitch.evaluation macro scores HOT 1
- 0.8 meta issue HOT 3
- sonify.time_frequency regression HOT 3
- Set warning stacklevels for validation HOT 1
- Replace scipy.fftpack with scipy.fft HOT 1
- Migrate to organization
- Separation test precision on OSX
- Fix display tests for matplotlib 3.9 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mir_eval.