Use docker labels rather than statically defined configs about diun

[moqmar]

Hm, I think having both possibilities would be great, so it's possible to "just enable diun" with a single-word-label, but also to directly configure it for more advanced options. I'll try to put something together. :)

[moqmar]

So, I'd suggest the following labels:

• -l diun just checks for Config.Image (so, the tag the container has been started with)
• -l diun='^1\.2\..*' enables watch_repo & checks for the matching tags (like include_tags)
• -l diun='1.2.*' - why not use wildcards if the tag name is valid except for the wildcard? This is also relevant for include_tags...
• -l diun=true is like -l diun
• -l diun=false disables diun explicitly

I'd also add to the watch config section:

watch:
  docker: true # or a path to the Docker socket
  unlabeled-containers: true # also watch unlabeled containers?
  stopped-containers: true # also watch stopped containers?

If that's fine, I can create a pull request for that. 🙃

[crazy-max]

Hi @moqmar,

Thanks for your suggestions!

I would prefer to work with fields. This way we could easily serialize to the same struct as the current static configuration:

• diun.enable=true/false
• diun.watch_repo=true/false
• diun.max_tags=0
• diun.include_tags.one=^1\.2\..*
• diun.include_tags.other=latest
• diun.exclude_tags.foo=^1\.2\..*
• diun.exclude_tags.bar=latest

diun.include_tags/exclude_tags is a map here.

What do you think? Anyway feel free to open a PR :)

[crazy-max]

@moqmar Of course, I was just stating all the labels and there will be default values.

[Leopere]

Glad to see this is still progressing in some way. My biggest concern with running containers is that you don't typically see any update notifications anywhere. You can use things like Ouroboros and the other one I've forgotten but that's assuming that all containers are created equal and sadly this is not the case. Sometimes you just use a container because it's the only one reliable enough to deploy.

At least being notified will make a big difference.

[crazy-max]

@Leopere Done through release 2.0.0

[Leopere]

Oh, that's very nice thank you! I'm looking forward to plugging this thing into my entire docker stack!