Comments (28)
I can handle this. Please may I proceed?
from creativecommons.github.io-source.
Sure @SamOdum, I see you've commented on a couple of other issues on this repo as well, please pick one issue at a time so that others have a chance too. Let me know which one you want to tackle first and I'll mark that one as in progress.
from creativecommons.github.io-source.
Thank you for responding. May I start with this one?
from creativecommons.github.io-source.
Go ahead.
from creativecommons.github.io-source.
Hi @kgodey ! Pleace may i work with you on this ?
from creativecommons.github.io-source.
@chimenekouomogne This is already in progress, there is a pull request for it.
from creativecommons.github.io-source.
@kgodey mam If this is not fixed I will love to work on this one.
Thank you.
from creativecommons.github.io-source.
@techievivek go ahead
from creativecommons.github.io-source.
@kgodey hello mam, I tried solving this issue but since all the blog posts need not have image how will we able to show the featured image for same, I think @SamOdum idea is one we can go with.
Or please suggest me something so that I can move forward with or think about it.
The main problem is with the featured image, the description part can be done easily.
Thank you.
from creativecommons.github.io-source.
We should use the first image on the page/blog post if it exists, otherwise we should not have a featured image at all.
from creativecommons.github.io-source.
@kgodey so in case if no images are part of blog/page can we use cc logo. So that it looks genuine and better while sharing.
from creativecommons.github.io-source.
I think it's best to skip the featured image entirely if there's no image in the post/page.
from creativecommons.github.io-source.
@kgodey hello mam, I have almost worked on this issue but just some queries before I start a pull request.
- For index page i.e. opensource.creativecommons.org , since I am getting first image by default(if there), so here it is not showing CC logo rather a black & white keyboard image, as that is the first image for this page.
- Description part of meta tag, I don't know what I have to put here, first, I thought to go with body(content part of post), but that is markdown content so we will need to strip it to get text content (there is a plugin too in lektor striphtmltags), but i am unable to install it, secondly we will have to slice the content(as post content can be very long) and there is again a plugin in lektor markdown-excerpt, but this is also not working.
Please help me so that i can initiate the PR.
Thank you
from creativecommons.github.io-source.
@kgodey hello mam, should i create a pull request and then you will check it out?
from creativecommons.github.io-source.
- that's fine
- what errors are you running into with the Lektor plugins?
from creativecommons.github.io-source.
@kgodey hello mam, I have added both striphtmltags and markdown-excerpt plugin to the project so that I can convert body content into plain text and then just get the first line content using markdown-excerpt.
I have added by running the command
lektor plugin add markdown-excerpt
lektor plugin add strip-html-tags
This is the content of file .lektorproject after I run the above command.
But none of them is working.
Below is the error I am receiving.
Progress till now
I have just added the image functionality, i.e. it will select an image if there.
{% set image = this.attachments.images.first() %}
{% if image %}
<meta property="og:image" content="{{ image | url }}" />
{% endif %}
Please suggest me how do I proceed with this?
Thank you
from creativecommons.github.io-source.
@kgodey hello mam, please look into this.
Thank you
from creativecommons.github.io-source.
@techievivek please create a PR so that I can see why the error is happening.
from creativecommons.github.io-source.
@kgodey mam, I have created a PR, please look into it.
Thank you
from creativecommons.github.io-source.
@kgodey hello mam, did u have a look at it?
from creativecommons.github.io-source.
Not yet, it will take me a couple more days, sorry.
from creativecommons.github.io-source.
@kgodey Ok mam, sure. I am looking at other repo under CC.
from creativecommons.github.io-source.
@kgodey Mam, can we just show the image (first one in the post) and the title while sharing on different platform.( we can skip the description part).
I am attaching a picture on how it looks while sharing for the above condition.
( The link part will be of the CC site, I am using ngrok to tunnel localhost).
If we can go with this I will update my PR.
Or else we just have to sort the description part somehow.
from creativecommons.github.io-source.
@kgodey mam please take a look at above suggestion.
from creativecommons.github.io-source.
@techievivek I think GitHub ate my last comment because I definitely replied to this :/
Yes, we can skip the description for now. Could you make a separate GitHub issue for adding the description once this is merged? We can tackle that separately.
from creativecommons.github.io-source.
@kgodey Yes mam I will do that. Also please take a look at one of the bug that I experienced today here #182
from creativecommons.github.io-source.
@kgodey I have created a new PR, please have a look. And I will add a new issue for the description part.
from creativecommons.github.io-source.
@kgodey I have added a new issue for description part, please have a look and suggest if I have to change anything.
#184
from creativecommons.github.io-source.
Related Issues (20)
- [Feature] Email field place holder not properly alligned HOT 5
- [RFC] Request for Comments: issues encountered
- [Change] Add `#cc-dev-searchportal` slack channel information to site HOT 1
- [Feature] Improve multi-author support: multiple gravatar images HOT 4
- Avatar image covers the content when inspect is opened HOT 3
- [Bug] some minute grammatical issues HOT 2
- [Bug] Align lists in Get Involved Section on Homepage HOT 6
- [Bug] Responsiveness of the website HOT 8
- Email textbox not optimized for mobile view HOT 15
- [Feature] Add "Other Opportunties" section to Work Programs overview HOT 6
- [Change] The `lektor-google-analytics` needs to be removed, due to its incompatibility with GA4 properties, and lack of updates
- [Bug] The twitter link redirects to the main CC page HOT 9
- Responsive issue in Nav element HOT 16
- Subscribe Button Issue: No Input Validation or Error Feedback HOT 2
- [Bug] Broken Link in the ReadME section HOT 1
- [Bug] The footer has old twitter logo that needs to be updated HOT 11
- [Feature] Recent Posts Design HOT 8
- Inconsistent height of div HOT 4
- Utilize organization default community health files HOT 2
- [Bug] README.md file out of date HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from creativecommons.github.io-source.