GithubHelp home page GithubHelp logo

Comments (28)

SamOdum avatar SamOdum commented on June 24, 2024

I can handle this. Please may I proceed?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

Sure @SamOdum, I see you've commented on a couple of other issues on this repo as well, please pick one issue at a time so that others have a chance too. Let me know which one you want to tackle first and I'll mark that one as in progress.

from creativecommons.github.io-source.

SamOdum avatar SamOdum commented on June 24, 2024

Thank you for responding. May I start with this one?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

Go ahead.

from creativecommons.github.io-source.

chimenekouomogne avatar chimenekouomogne commented on June 24, 2024

Hi @kgodey ! Pleace may i work with you on this ?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

@chimenekouomogne This is already in progress, there is a pull request for it.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey mam If this is not fixed I will love to work on this one.
Thank you.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

@techievivek go ahead

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey hello mam, I tried solving this issue but since all the blog posts need not have image how will we able to show the featured image for same, I think @SamOdum idea is one we can go with.
Or please suggest me something so that I can move forward with or think about it.
The main problem is with the featured image, the description part can be done easily.
Thank you.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

We should use the first image on the page/blog post if it exists, otherwise we should not have a featured image at all.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey so in case if no images are part of blog/page can we use cc logo. So that it looks genuine and better while sharing.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

I think it's best to skip the featured image entirely if there's no image in the post/page.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey hello mam, I have almost worked on this issue but just some queries before I start a pull request.

  1. For index page i.e. opensource.creativecommons.org , since I am getting first image by default(if there), so here it is not showing CC logo rather a black & white keyboard image, as that is the first image for this page.
  2. Description part of meta tag, I don't know what I have to put here, first, I thought to go with body(content part of post), but that is markdown content so we will need to strip it to get text content (there is a plugin too in lektor striphtmltags), but i am unable to install it, secondly we will have to slice the content(as post content can be very long) and there is again a plugin in lektor markdown-excerpt, but this is also not working.
    Please help me so that i can initiate the PR.
    Thank you

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey hello mam, should i create a pull request and then you will check it out?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

@techievivek

  1. that's fine
  2. what errors are you running into with the Lektor plugins?

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey hello mam, I have added both striphtmltags and markdown-excerpt plugin to the project so that I can convert body content into plain text and then just get the first line content using markdown-excerpt.
I have added by running the command

lektor plugin add markdown-excerpt
lektor plugin add strip-html-tags

This is the content of file .lektorproject after I run the above command.
lektor diff
But none of them is working.
Below is the error I am receiving.
error striphtmltags

Progress till now

I have just added the image functionality, i.e. it will select an image if there.

{% set image = this.attachments.images.first() %}
      {% if image %}
<meta property="og:image" content="{{ image | url }}" />
      {% endif %}

Please suggest me how do I proceed with this?
Thank you

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey hello mam, please look into this.
Thank you

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

@techievivek please create a PR so that I can see why the error is happening.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey mam, I have created a PR, please look into it.
Thank you

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey hello mam, did u have a look at it?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

Not yet, it will take me a couple more days, sorry.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey Ok mam, sure. I am looking at other repo under CC.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey Mam, can we just show the image (first one in the post) and the title while sharing on different platform.( we can skip the description part).
I am attaching a picture on how it looks while sharing for the above condition.
Screenshot_20200219-164139
( The link part will be of the CC site, I am using ngrok to tunnel localhost).
If we can go with this I will update my PR.
Or else we just have to sort the description part somehow.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey mam please take a look at above suggestion.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 24, 2024

@techievivek I think GitHub ate my last comment because I definitely replied to this :/

Yes, we can skip the description for now. Could you make a separate GitHub issue for adding the description once this is merged? We can tackle that separately.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey Yes mam I will do that. Also please take a look at one of the bug that I experienced today here #182

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey I have created a new PR, please have a look. And I will add a new issue for the description part.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on June 24, 2024

@kgodey I have added a new issue for description part, please have a look and suggest if I have to change anything.
#184

from creativecommons.github.io-source.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.