GithubHelp home page GithubHelp logo

Comments (14)

kgodey avatar kgodey commented on June 23, 2024 1

@accakks I can't assign to you since you're not in our GitHub organization, our Contributing Code guidelines mentions that if there's a comment on the issue saying someone is working on it, other people shouldn't work on it so you should be good.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 23, 2024 1

@sgrepos I haven't updated any existing issues with the label yet, let me know if there are more I should update.

from creativecommons.github.io-source.

realsidg avatar realsidg commented on June 23, 2024

The bootstrap template is pretty much fine. I added a meta view-port and made a pr as it was missing. That will fix it on the website.

from creativecommons.github.io-source.

hugosolar avatar hugosolar commented on June 23, 2024

PR #22 merged that add viewport meta
There are a lot of style issues to fix, though

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 23, 2024

I narrowed the scope of this issue a little and I'll create a separate issue for setting up SASS.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 23, 2024

Created #26 for Sass.

from creativecommons.github.io-source.

accakks avatar accakks commented on June 23, 2024

Hi, I would like to work on this.
I'll start by analyzing what style issues are there exactly and work on them.

Is there anything you might like to add?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 23, 2024

The only one I can think of is the footer having overflowing text and whitespace below it when the screen is narrow enough for the text to not fit in the footer.

Screenshot:
Technology at Creative Commons — Creative Commons on GitHub

from creativecommons.github.io-source.

accakks avatar accakks commented on June 23, 2024

@kgodey Can you assign this to me or mark in progress?

from creativecommons.github.io-source.

sgrepos avatar sgrepos commented on June 23, 2024

@kgodey this is not showing up as "in progress" currently, although I know you just recently updated that inside the contribution guidelines. I'm just commenting here to express my interest in working on it, in case it might be available!

@accakks can you update us and let us know if you're still working on this? :)

from creativecommons.github.io-source.

accakks avatar accakks commented on June 23, 2024

@sgrepos Yes I'll be working on this. If I'm not able to I'll let you know in 2-3 days.

from creativecommons.github.io-source.

sgrepos avatar sgrepos commented on June 23, 2024

@accakks Alright, great! 👍

from creativecommons.github.io-source.

accakks avatar accakks commented on June 23, 2024

@kgodey I have created a PR #36 fixing text and whitespace overflow issue.
Do you think I should take time to explore and fix other mobile issues (if any) on the same PR or I should create other PR(s) of other issues if found?

from creativecommons.github.io-source.

kgodey avatar kgodey commented on June 23, 2024

@accakks that would be great, @hugosolar may have other specific examples of things to fix too.

from creativecommons.github.io-source.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.