GithubHelp home page GithubHelp logo

Comments (17)

techievivek avatar techievivek commented on July 22, 2024 1

@dhruvkb @kgodey i have updated as suggested and initiated a new PR , i am also attaching a demo image for the same.
custom-404
If there is anything else i can improve upon please suggest.
Thank you.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@kgodey i would like to work on this.
Thank you

from creativecommons.github.io-source.

kgodey avatar kgodey commented on July 22, 2024

@techievivek go ahead! Please post your design on your pull request for feedback.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@kgodey could you please help me which one is better and should I add some important links in case the user would like to navigate once they are lost.

First one

error-404-2

Second one

error-404-1

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@kgodey mam please respond so that i can proceed further.
Thank you.

from creativecommons.github.io-source.

dhruvkb avatar dhruvkb commented on July 22, 2024

@techievivek if I may interject, I just want to make sure that you're using CSS for creating these designs and not images, because they may not scale that well. Even if you're using SVGs, they won't achieve the level of interactivity or internationalisation as HTML content which can be manipulated using JS or translated based on user locale.

In terms of feedback, I really like the first one because I'm a huge fan of the dark theme but I'm not sure how your image would look on a 16:9 aspect ratio (a more aspect-adjusted image would help). Also, you should indeed add some important links and the CC logo at appropriate positions on the page.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@dhruvkb yes i am using HTML, CSS for the design(no images are used), but in first one the shapes has been created using svg, and the second one is just HTML,CSS & JS without svg.
So please tell me should i go with first one(it is completely responsive).

from creativecommons.github.io-source.

dhruvkb avatar dhruvkb commented on July 22, 2024

That decision is upto @kgodey. I just wanted to alleviate my concerns. She will respond once work resumes in her TZ. Feel free to contribute to other open issues in the meantime!

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

I have added SVG image as a placeholder(showing 404 error) which is completely responsive for all the devices, please check it.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on July 22, 2024

hey @techievivek, sorry for the delay in responding. Your designs are good but we'd like a really simple/clean page that matches the rest of the site. It would be ideal if you could show the header and footer of the site as well.

Some examples along the lines of what I was thinking of (but with the header and footer added):
https://egyptianstreets.com/wp-content/uploads/2017/07/404.jpg
https://www.yo-kart.com/blog/wp-content/uploads/2018/01/404-Page-not-found.jpg

Also, please make sure to use CC's brand colors: https://creativecommons.org/2019/10/30/cc-style-guide/

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@kgodey This is what i have PR and as a placeholder i am using SVG image with the same theme color as CC's brand color.(It is completely responsive and i have testesd it for different browser size).

Navbar part

header

Footer Part

footer

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@kgodey it contains a link(Return Home) to redirect user to the Hompeage.

from creativecommons.github.io-source.

kgodey avatar kgodey commented on July 22, 2024

Hi @techievivek. The header and footer looks good! Please remove the image and just use text for the "404" part. Thanks!

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

@kgodey i have initiated a new PR with the design suggested by you, i am attaching a demo image for the same. Please check it and let me know if there is anything i can improve upon.
Thank you.
404-custom

from creativecommons.github.io-source.

dhruvkb avatar dhruvkb commented on July 22, 2024

@techievivek sorry for these incremental iterations but why the green shadows? Also the frown emoji looks out of place.

from creativecommons.github.io-source.

techievivek avatar techievivek commented on July 22, 2024

Ok...thank you for the suggestions. I will change accordingly.
Can you kindly let me know if I should also remove the shadow completely or just change the color to black.

from creativecommons.github.io-source.

dhruvkb avatar dhruvkb commented on July 22, 2024

Black would look good.

from creativecommons.github.io-source.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.