GithubHelp home page GithubHelp logo

Comments (7)

CreaturesInUnitards avatar CreaturesInUnitards commented on September 26, 2024 1

Great feedback, and thanks! I couldn't agree more. Check out my datepicker to see where this is going.

from mithril-timepicker.

CreaturesInUnitards avatar CreaturesInUnitards commented on September 26, 2024

@gilbert (wanna check this for me)[https://tinyurl.com/y74cyanu] and weigh in?

from mithril-timepicker.

gilbert avatar gilbert commented on September 26, 2024

Much better! :) The feeling of uneasiness is gone.

Separately, there's a small bit of jank when you close Time 1 in your example; it looks like the z-index for Time 2 is above Time 1 during Time 1's closing transition (apologies for the demo mode overlay):

bug
`

from mithril-timepicker.

CreaturesInUnitards avatar CreaturesInUnitards commented on September 26, 2024

heh, of course! Nice catch, thanks :)

from mithril-timepicker.

CreaturesInUnitards avatar CreaturesInUnitards commented on September 26, 2024

@gilbert I really appreciate the feedback. Now: any reason I shouldn't close this?

from mithril-timepicker.

gilbert avatar gilbert commented on September 26, 2024

I still see the bug in the readme flems. If it's fixed in repo, maybe close after updating the readme? :)

from mithril-timepicker.

osban avatar osban commented on September 26, 2024

The demo has another issue: when clicking on hours/mins, and clicking on it again after the editor opens, the console.log is undefined. I think the event handler should be changed to something like onchange: () => console.log(time1).

from mithril-timepicker.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.