File with no id3 tags returning input instead of emitting error about id3-parser

[creeperyang]

@dvdcxn v1.2 has fixed this, and you can always check stats.version to determine whether the id3 parse worked.

• If invalid argument passed, the promise rejected.

• If the buffer is not valid id3v1 or id3v2 buffer, you get {version: false}.

• Otherwise, you get

  {
     version: {
        v1: false | object,
        v2: false | object
     }
  }

Enjoy the new version.

[creeperyang]

@dvdcxn I think there is no need to change id3-parser's behavior.

You could wrap the lib yourself, such as code below:

function analyseFile(fileName) {
	let _readFile = bluebird.promisify(readFile);
        let content;
	return _readFile(fileName)
                .then(buf => {
                       content = buf;
                       return buf;
                 })
		.then(id3.parse)
		.then(stats => {	
			if(stats.version){	
				return stats;
			}
			else{
				throw `Couldn\'t determine id3 data for file ${fileName}`;
			}		
		})
		.catch(err => {
                    return content;
                });
}

[chordmemory]

@creeperyang Will do. Is checking whether the version is truthy a reliable enough way to determine whether the id3 parse worked?

[creeperyang]

No. If the buffer's length is less than required, false is returned.

// use this instead
if (stats && stats.version) {}

Good question! I should make the promise rejected when the buffer is less than expected.