GithubHelp home page GithubHelp logo

Comments (9)

crimx avatar crimx commented on August 15, 2024 1

Just found out the bug 😂. I deserve a slap in the face. https://github.com/crimx/ext-github-release-notifier/blame/master/src/api/storage.js#L109-L111

from ext-github-release-notifier.

crimx avatar crimx commented on August 15, 2024

It uses the Chrome Extension Sync storage. Not sure about the timing. But I assume the results would be merged successfully with the fix on #1 .

from ext-github-release-notifier.

falcucci avatar falcucci commented on August 15, 2024

Yes, totally. I'm also using firefox here, surely this would fix the issue.

from ext-github-release-notifier.

crimx avatar crimx commented on August 15, 2024

Close for now. Feel free to reopen if it doesn't work.

from ext-github-release-notifier.

falcucci avatar falcucci commented on August 15, 2024

@crimx when you released the new version of ext-github-release-notifier, the popup isn't showing the repositories anymore. Only ext-github-release-notifier.

I would be able to confirm in another notebook later about the sync, but why did my repositories disappear from there?

from ext-github-release-notifier.

falcucci avatar falcucci commented on August 15, 2024

I did wht you said here and the results are the same: only ext-github-release-notifier in the local storage and I didn't hit the CLEAR ALL button accidentally as well 😀

from ext-github-release-notifier.

crimx avatar crimx commented on August 15, 2024

What do you mean only ext-github-release-notifier? Like only a string?

from ext-github-release-notifier.

falcucci avatar falcucci commented on August 15, 2024

Sorry I mean only this repository in the popup list:


captura de tela de 2018-04-18 15 30 02

>>> browser.storage.sync.get(null, console.log)
{
  "repos": [
    "crimx/ext-github-release-notifier"
  ]
}

>>> browser.storage.local.get(null, console.log)
{
  "name": "crimx/ext-github-release-notifier",
  "watching": "all",
  "etag": "W/\"34f4f90d4d3e1f96dd698556615797c2\"",
  "last_modified": "Wed, 18 Apr 2018 17:16:58 GMT",
  "avatar_url": "https://avatars3.githubusercontent.com/u/6882794?v=4",
  "author_url": "https://github.com/crimx",
  "published_at": 1524071818000,
  "html_url": "https://github.com/crimx/ext-github-release-notifier/releases/tag/v0.2.0",
  "tag_name": "v0.2.0",
  "zipball_url": "https://api.github.com/repos/crimx/ext-github-release-notifier/zipball/v0.2.0",
  "tarball_url": "https://api.github.com/repos/crimx/ext-github-release-notifier/tarball/v0.2.0",
  "assets": [
    {
      "browser_download_url": "https://github.com/crimx/ext-github-release-notifier/releases/download/v0.2.0/Release-Notifier-for-Github_v0.2.0.crx",
      "name": "Release-Notifier-for-Github_v0.2.0.crx",
      "icon_name": "package"
    },
    {
      "browser_download_url": "https://github.com/crimx/ext-github-release-notifier/releases/download/v0.2.0/Release-Notifier-for-Github_v0.2.0.xpi",
      "name": "Release-Notifier-for-Github_v0.2.0.xpi",
      "icon_name": "package"
    }
  ]
}

from ext-github-release-notifier.

falcucci avatar falcucci commented on August 15, 2024

I had about 15 repositories in the popup list before.

from ext-github-release-notifier.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.