Comments (2)
After skimming again though our assert usages, I am closing that issue.
Asserts have a defined use case in C++, that is, check a condition in debug build and don't check (remove that code) in release builds.
There are many asserts, and they are used in the spirit of that use case.
If there is any special assert that should be implemented as a runtime exception also in release builds, there should be specific ticket for it, so it can be discussed. And if there is an exception implementation, tests need be added to trigger that problem and verify exceptions are thrown accordingly.
A general ticket like this, that wants to remove all asserts, can not be implemented, since asserts have a real use case.
from djinni-support-lib.
I agree that there is no safety , except a check in a debug build (with an assert failure).
But I have difficult to see what else to do.
Exceptions, just crash .... ? This might result in the same , because, how could you handle such an exception.
And then there is of course the question of the likeliness of such an event, and if we are willy to pay the price of additional code in the release build for this scenario?
It would be good to find answers to those questions to come up with a strategy for a better solution, if there is any
from djinni-support-lib.
Related Issues (20)
- Windows make install does not install the shared library
- Use CMake djinni-support-lib target in integration tests HOT 2
- Remove CMake option DJINNI_STATIC_LIB in favor of BUILD_SHARED_LIBS
- assertion failure on Android AVD on Apple M1 HOT 20
- `DJINNI_WITH_PYTHON` does not build on Windows
- Header wrapper_marshal.hpp missing in the installed header files
- Python windows build problems HOT 2
- Python CFFI build problem on Windows HOT 3
- Update conan documentation
- Java/JNI thread problems HOT 7
- Some warnings for mac catalyst HOT 3
- JNI_OnLoad/JNI_OnUnload - default implementation not optional HOT 7
- Problems when use Conan recipe and iOS + Darwin Toolchain HOT 4
- Conan recipe and java files HOT 2
- Problems when use new support library for iOS HOT 8
- Suggestion to use two main files for JNI HOT 1
- Support for weak pointers HOT 10
- I use djinni about 6 years , but still not support inherit HOT 4
- C++/CLI checks are broken HOT 10
- Add cmake version info to the CI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from djinni-support-lib.