Subprotocol error when creating connection with about autobahn-js

[iamciroja]

Hello, everyone! Are there any good news on this issue? :)

[DamiToma]

I'm not sure what the state of this issue is, but I tested with ws v8.6.0 and the reason it's erroring is that there's a regex test failing. Autobahn passes both JSON and webpack serialization split by a comma, but ws is expecting an array.

I removed the join statement to pass an array and it's working beautifully now. Does it make sense to migrate to v8 and remove that?

[luixo]

@oberstet
It seems like you're maintaining the repository
The small change (removing the join and upgrading to the new ws version) can make users' lifes better. If that's too much - the condition may be added to check ws version before joining protocols.
We already have a PR for a quick fix: #552, I can create a PR for a proper one.

[DamiToma]

@oberstet I would suggest to also update the README, as it can be misleading for newbies. Initially I thought it supported up to version 2, we can probably get rid of the comment for Node V4.5.0 (I guess no one has been using that for years).

[venki91]

Using >= instead of default ^ in the package.json file is causing the problem. A major version of ws module is getting installed, and it is breaking the autobahn module.
Why are we using >= in package.json? Is there a reason?

[venki91]

I see. You are supporting from ws v1.0.

[venki91]

Can you put an upper limit to the dependency module versions so that they don't break autobahn in future.
https://semver.npmjs.com/

[gvatsov]

I used the npm-force-resolutions package for my project as a workaround for this issue to point to the non-broken ws version 7.5.3.

[oberstet]

just a quick note, what @DamiToma suggests sounds good! @luixo no need for checking for old ws version, we can just bump the minimum version required to v8.6. so yeah, a PR would be awesome, I can merge ..