Helm chart is not helm3-compatible about k-rail

[dustin-decker]

As of https://github.com/cruise-automation/k-rail/releases/tag/v2.0.0, automated helm chart releases are working! Namespace was removed from the helm chart to make it helm3 compatible. The namespace exclusion label has changed (a breaking change, so hence the major version increase)

Thanks for your help @funkypenguin

[funkypenguin]

Note that this chicken/egg problem may be resolved with Helm v3.0.3, released 4h ago, with this fix : helm/helm#7266

[dustin-decker]

Hmm, I think Helm 2 required the namespace to be created.. I'm curious to find what the best practice is here and apply it. I suspect creating the namespace separately as you suggested may be the best option.
I think name= or app= convention is pretty typical though and is what I expect to see for label selectors.

[alpe]

Note that this chicken/egg problem may be resolved with Helm v3.0.3, released 4h ago, with this fix : helm/helm#7266

I can confirm that the issue still exists with helm v3.0.3

[netflash]

Up.
Can we at least remove the namespace? I can provide a PR for that

[funkypenguin]

If it helps, here's a version I'm using with the namespace removed:

https://github.com/funkypenguin/helm-k-rail

[dustin-decker]

The solution that @funkypenguin proposed sounds fine. If one of you makes a PR we will accept it. Thanks.

[funkypenguin]

@dustin-decker I'll get on it. To be clear, which part of my proposed solution sounds fine? Just the removal of the namespace from the template, or also the changing of the exclusion label?

(The reason I suggest changing the label, is that in my experience when dealing with excluding certain namespaces from mutatingwebhooks, you come across self-documenting labels like this:

kiali.io/member-of=istio-system
istio-injection=enabled
certmanager.k8s.io/disable-validation=true

[dustin-decker]

I meant all of the above,

• the exclusion label
• removal of namespace for helm3 compat

Thanks for #72.

Do we need to move the chart under ./chart rather than ./deploy for the helm repo to work? Currently the action triggers on changes to the charts folder.

[funkypenguin]

Re #72, that was an oversight, sorry! Either we move the chart to /charts/k-rail, which is what the action expects by default, or we update the workflow to use the current /deploy/helm path. I'm happy to submit a PR for either :)

[dustin-decker]

I think helm expects repos have a charts directory, so let's try that.