Atom does not exit correctly about atom-ide-crystal

[keplersj]

crystal-lang-tools/scry#69 and crystal-lang-tools/scry#71 have both been resolved. This issue should be fixed with the next update to scry and ide-crystal.

[keplersj]

I'm not sure I understand how this is due to ide-crystal... This issue doesn't occur without ide-crystal installed?

[keplersj]

I see that you have linter+linter-ui-default+busy-signal+intentions installed alongside atom-ide-ui. My first guess is that this could be causing your problem. atom-ide-ui is itself a linter consumer. Having them all installed at once could possibly create conflicts and other issues for your editor.

[keplersj]

I also see that you have ide-haskell and haskell-ghc-mod. While compatible with Atom IDE, they are not totally integrated with it. (ref: atom-haskell/ide-haskell#215) I recommend ide-haskell-hie for integrating Haskell with Atom IDE.

[vypxl]

The issue does not occur without ide-crystal installed or when it's disabled. I will test your proposals later today

[keplersj]

If you can't reproduce it without ide-crystal it is definitely at fault, and my other suggestions won't fix the problem. I'll try to reproduce it soon.

What I can't figure out of the top of my head is what makes ide-crystal different from ide-rust in this scenario. They both make use of the same atom-languageclient under the hood. Any thoughts @damieng?

[damieng]

This can happen if the language server does not correctly respond to the shutdown message.

The same process happens when shutting down the server because it is no longer in use (i.e. close the last opened crystal file) and might be easier to troubleshoot as Atom isn't unloading at the time so you can see the debugging messages (enable with atom.config.set('core.debugLSP', true) )

[keplersj]

@faustinoaq Is Scry handling shutdown messages correctly? The only code I see that handles it is at https://github.com/crystal-lang-tools/scry/blob/4b699f6a7bce2fb2f866e0c2b4ab61fd4931491d/src/scry/context.cr#L25-L35

[damieng]

I don't think it is - it's supposed to send a response to the shutdown message rather than just terminate.

There is also an exit message which is supposed to do what Scry's current shutdown does.

https://microsoft.github.io/language-server-protocol/specification

[faustinoaq]

Is Scry handling shutdown messages correctly?

@keplersj I think so, although I don't know if scry is still full compatible with latest LSP specification

I don't think it is - it's supposed to send a response to the shutdown message rather than just terminate.

@damieng Oh, you're right, seems scry isn't sending a shutdown response, I just remember I added exit(0) some time ago as a workaround 😅

BTW, these are my VSCode logs (working just fine)

D, [2018-03-29 13:59:03 -05:00 #6893] DEBUG -- : Content-Length: 58
D, [2018-03-29 13:59:03 -05:00 #6893] DEBUG -- : 
D, [2018-03-29 13:59:03 -05:00 #6893] DEBUG -- : {"jsonrpc":"2.0","id":1,"method":"shutdown","params":null}
I, [2018-03-29 13:59:03 -05:00 #6893]  INFO -- : ...your session has ended

Full logs here: scry.out.tmNDE6.zip

[faustinoaq]

BTW, Thank you for the PRs! 😄