GithubHelp home page GithubHelp logo

PA speed control about pilot-assistant HOT 31 CLOSED

crzyrndm avatar crzyrndm commented on August 26, 2024
PA speed control

from pilot-assistant.

Comments (31)

DeputyLOL avatar DeputyLOL commented on August 26, 2024

Also, why does direct throttle input have a speed setting? :3

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

"Also, why does direct throttle input have a speed setting? :3"

  • If it says speed somewhere, that'd be a typo.
  • Adding the speed settings to the presets is probably a good idea.
  • The inconsistency is something I know about but haven't been able to locate the cause of since I copied it almost line for line from FAR. It's pending investigation
  • I wasn't aware the RPM had implemented any compatibility so I'm not entirely sure of the details. I did have a conversation with MoarDV somewhere about it but I can't seem to locate it. I don't think I've changed the function signatures since then though so I don't know what's happening there

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

I can change the throttle % into IAS, TAS or EAS and change its unit. If I set it to knots than 100% becomes 50ish%. you shouldn't be able to change that in the direct throttle control.

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

https://i.imgur.com/iWKad22.jpg
Yea, that shouldn't be happening...

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

are you considering impletementing some of the features of kramax autopilot?
such as the waypoint navigation?

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

I will not be. The level of Automation used in Kramax is beyond the scope I have for PA

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

Aww...

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

when I use RPM to input numbers into the speed control, if set to anything other than m/s the numbers change don't match the number inputted.

Probably something to do with the conversion into different units.

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

Most likely RPM isn't aware of the speed settings and all speed inputs are being treated as m/s (which is mostly ok, because PA uses only m/s in the background, but it is slightly confusing from a user perspective).

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

is there any fix?
I also notice that when not set to m/s, the speed control is a bit buggy. When engaging, it will target a speed different from your current speed and x and z don't change by 100 intervals.

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

I'll have a poke at the engaging issue.
All hotkeys, I can just about guarantee, are still working in m/s

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

X and z do change the speed but not in 100 intervals.

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

What I meant was that if you switch back to m/s, the intervals will be 100's still, they're just transformed by the conversion factor. Regardless, I've just fixed the missing conversion

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

image
The conversion between RPM is still off a bit but it looks like it is slightly better
(RPM says 299knots, PA says 289knots)

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

Looking back, the gap has actually got bigger....
But the RPM to PA transfer works and matches.

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

TAS / IAS / EAS ?

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

IAS

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

in knots

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

This is what I'm working on in RPM to narrow the gap.

RPM_MAPPED_VARIABLE
{
sourceVariable = ALTITUDE
sourceRange = 100,10000
mappedVariable = PA_SPEEDINPUT_ALTITUDE
mappedRange = 479,493.6
}

RPM_MAPPED_VARIABLE
{
sourceVariable = PERSISTENT_MCP_SpeedInput
sourceRange = 0,500
mappedVariable = PA_SPEEDINPUT
mappedRange = 0,MAPPED_PA_SPEEDINPUT_ALTITUDE
}

// PA RPM
//100m - 500 (522)
//100m - 200 (208.8)
//10000m - 500 (506.4)
//10000m - 200 (202.7)

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

At the bottom is a little table that shows what PA was showing and RPM was showing at different heights

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

Alright, the difference is how atmospheric density is being calculated. If you fly to ~45 degrees N/S on Kerbin, the differences will disappear because that is the value used by FAR/RPM. My understanding of this would be that neither has updated the method to account for the thermal system which causes the atmospheric density to vary between the polar and equatorial regions (they use a constant density for a given altitude).

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

ahhhh... will you keep it as it is or will you change it to fit the other mods?

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

I'll poke FAR and see what the expert has to say :P

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

It says there are new extension for RPM on the releases page, anything new working with RPM?

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

not until RPM adds support for them. I did notify MoarDv of the changes here

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

Do you think you could expose the green number next to the heading in RPM?
I'm working on a flight director system that tells how to manually fly what you've entered into the autopilot.
I am completely stumped on the heading part as it goes from 360 to 1. If I could use the number from PA or at least know how to get to it, I could finish a big section of the horizontal flight director.

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

The green number is just a little math.

targetDelta = target - current;
if (targetDelta < -180) targetDelta += 360;
if (targetDelta > 180) targetDelta -= 360;

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

ok thanks, ill try and reproduce that in RPM

from pilot-assistant.

DeputyLOL avatar DeputyLOL commented on August 26, 2024

I got the roll section done. I'm stumped on how to do the pitch though because there is so many variables.
I noticed that FAR has made a dev build with the updated IAS. Have you asked MoarDv about RPM yet?

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

Waiting to see how FARs numbers line up, the earlier commit was a little off and haven't tested the newer one yet (EDIT: It's still having issues)

from pilot-assistant.

Crzyrndm avatar Crzyrndm commented on August 26, 2024

FAR matches, RPM has acknowledged the issue as a bug. Closing this

from pilot-assistant.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.