Idea: ability to set a default unit, then use Numbers instead of strings. about jss

[trusktr]

Or perhaps even something more advanced that would let default units to be specified for specific properties, e.g.

jss.createStyleSheet(style, {
  units: {
    default: 'px',
    'font-size': 'em' // override default
  }
});

[kof]

I already had a default for numbers - px. Removed it.

This is problematic, not all styles can be defined in em, not all in px

f.e. z-index is pure number
border can't be in %

Also more or less ok from the performance are values with just one definition, like height: 10, but if you get something like border: 1 solid red; you need to parse more to add unit to the number.

Maybe it is a task for a preprocessor.

[kof]

By having more than 1 default unit, you make styles uncomposable in case you want to mix styles with different default units to create a new style.

[kof]

I am not sure all the problems worth it.

[trusktr]

True. I haven't tried composing yet. Closing since yeah, it sounds complicated. xD

[kof]

I am still thinking to make the px default similar to jquery as a jss plugin.

[trusktr]

gss also uses a px default.

[kof]

https://github.com/jsstyles/jss-px

works same way as in jquery.

[trusktr]

OOOOhhhh yeaaaaah. Niiiice.