GithubHelp home page GithubHelp logo

Comments (20)

ctrager avatar ctrager commented on June 12, 2024

@ivangrek - This might be a more fun thing to work on. This is how it works now:
Screenshot from 2020-12-09 14-19-07

from budoco.

ctrager avatar ctrager commented on June 12, 2024

When you change description or details, you'll get a history post that's like this. If you hover where it says "hover to view" you get what you see in the screenshot above. What I want is more [click to view] and then a nice display of the text. Or, to be really cool, you could click to get a side-by-side diff of the before and after.
Details changed from [hover to view] to [hover to view] by admin on 12/9/2020 8:35:47 AM post #88

from budoco.

 avatar commented on June 12, 2024

I see only tooltip.

image

from budoco.

 avatar commented on June 12, 2024

Do you want to show a modal on click?

from budoco.

 avatar commented on June 12, 2024

Will it be correct?

Details changed by admin on 09.12.2020 22:31:36 post#14 [click to view]

Do you want to keep this message flow?

from budoco.

 avatar commented on June 12, 2024

image

from budoco.

ctrager avatar ctrager commented on June 12, 2024

Not sure I understand your question. The point of this issue is I want the user to be able to see what the text WAS in the past.
With the dropdowns, I can just say changed form "A" to "B", because the names are short.
With details and description, there's too much text to display so I don't want to show it until the user asks.
So, my title="before_val", that was a very quick and dirty way, but it's ugly and not very good. I want it nicer.
Either, display the text in a nice modal window, or, even more exciting, display a side-by-side diff.

from budoco.

 avatar commented on June 12, 2024

Ok. I do.

from budoco.

ctrager avatar ctrager commented on June 12, 2024

I found this: https://github.com/rtfpessoa/diff2html
I have no experience with it, but it might be worth exploring.

from budoco.

 avatar commented on June 12, 2024

1

from budoco.

 avatar commented on June 12, 2024

I found this: https://github.com/rtfpessoa/diff2html

diff format needs

from budoco.

ctrager avatar ctrager commented on June 12, 2024

Things to think about:
What is the size of your popup window?
What if there's just a small amount of text? Do you resize the window small?
What if there's a huge amount of text? You need to set a max size and then show scrollbars.
When you think you are done, let me know.
So the idea of showing a side-by-side diff, that's not something you like? That's not something you can do?

from budoco.

 avatar commented on June 12, 2024

What is the size of your popup window?
What if there's just a small amount of text? Do you resize the window small?
What if there's a huge amount of text? You need to set a max size and then show scrollbars.

The height depends on the content.

So the idea of showing a side-by-side diff, that's not something you like? That's not something you can do?

I like side-by-side diff, but it needs research to use.

from budoco.

ctrager avatar ctrager commented on June 12, 2024

Test with content that's taller than the height of the screen.

from budoco.

 avatar commented on June 12, 2024

This style breaks the layout as it is very general. (<div>)

image

from budoco.

ctrager avatar ctrager commented on June 12, 2024

It's a default. margin: 0, that's a default too. I picked a default that would result in me doing the least overriding. margin: 0, that would be a default that I'd be overriding a lot.

from budoco.

ctrager avatar ctrager commented on June 12, 2024

I'm not saying that my way is the best, but I am saying that whether the default is 0 or whether the default is 15, it would frequently need to be overriden.

from budoco.

 avatar commented on June 12, 2024

I'm not saying that my way is the best, but I am saying that whether the default is 0 or whether the default is 15, it would frequently need to be overriden.

Sorry. I have no control over how rude or inappropriate the phrases can be. (My phrases.)

from budoco.

ctrager avatar ctrager commented on June 12, 2024

done

from budoco.

 avatar commented on June 12, 2024

👍

from budoco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.