GithubHelp home page GithubHelp logo

Comments (2)

ctrlplusb avatar ctrlplusb commented on May 17, 2024 1

Hey @wmik 👋

Thanks for opening this!

You are correct...

https://unpkg.com/[email protected]/dist/redux.js
https://unpkg.com/[email protected]/dist/redux-thunk.js

😊

Would you be open to creating a PR to fix?

Glad you are liking the package. 👍

Have you been trying to use it much within a UMD context? Are you loading directly in the browser? I was wondering if I should consider bundling all the dependencies, except for React and React DOM, into the UMD build to avoid more difficult initial setups. I pretty much always work from a Node based environment with a bundler so I am not the best to decide this. Would appreciate your thoughts. 👍

from easy-peasy.

wmik avatar wmik commented on May 17, 2024 1

Sure I'd be happy to take this.

Yes I'm attempting to load it directly using a script tag which also requires the dependencies to be setup manually.
I'll try testing amd as well while applying the patch.

Side note:

  • Not sure how you feel about bundling prop-types for production. I noticed it's only used here
  • Also doubt shallowequal has a umd distribution but it should be easy to create one since it's relatively small.

from easy-peasy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.