Comments (10)
I would like to see a test or feature that fails without your fix before adding this.
Also, please respect the coding conventions already in the code - 4 spaces indentation.
And finally, if you fix several unrelated things on your fork, please make a branch for each - that makes it easier for me to merge stuff in. (Your maven stuff doesn't look ready yet).
from cuke4duke.
Any progress on adding tests?
from cuke4duke.
I've been on vacation the last days, need to catch up at work a little, than I will look into writing the corresponding tests.
I'll post a reply here on the issue when I'm done.
from cuke4duke.
I've implemented a testcase, which shows the problem not on a file level (.class files of anonymous and inner classes being picked up) but by directly using addClass on GuiceFactory.
Unfortunately, I'm not experienced enough in Git to remove the Maven stuff from the branch of the fix, but the fix only concerns GuiceFactory, GuiceFactoryTest and SomeModule.
If you can give me a hint about how I can split off the Maven stuff I will do that as well.
from cuke4duke.
Thanks for that. Don't worry about separating the stuff now. I can cherry-pick the commits I want. Here is a rough guide you can follow if you should want to contribute more: http://wiki.github.com/dchelimsky/rspec/topic-branches
(instead of git format-patch master, just do a git push origin my_topic)
from cuke4duke.
Thanks for developing such a great testing tool!
I think I got that with git, next time it'll be a clean fast-forward :)
Should I close the ticket or do you close it once you've reviewed the changes?
from cuke4duke.
Thanks mate. I'll close the ticket when I have merged in your commits and pushed them to my repo. Hope to get to it within a week, hopefully less. Definitely before next release.
from cuke4duke.
Cleaned up indentation and code. Closed by 8158505
from cuke4duke.
With respect to indentation - please use the conventions already present in the code - 4 space indentation.
from cuke4duke.
Oops, sorry...
Just writing some Scala stuff, for which indentation is 2 spaces. Forgot to set it back in Eclipse before formatting...
from cuke4duke.
Related Issues (20)
- Antlib should define all tasks HOT 1
- Cannot get maven-cuke4duke-jump-start to work.... HOT 3
- cuke4duke wiki has dead links HOT 5
- gherkin 2.4.0 breaks cuke4duke 0.4.3/0.4.4 running using maven HOT 2
- The plugin 'org.apache.maven.plugins:maven-cuke4duke-plugin' does not exists HOT 1
- cuke4duke-maven-plugin is does not use username/password for proxy connection HOT 2
- OutOfMemoryError caused by SpringFactory HOT 1
- Cuke4Duke StepMother still using announce
- Cucuber 1.0.1 breaks cuke4duke HOT 10
- Errors while running java example "HelloCucumber" HOT 9
- java example hangs
- Configure Source Directory
- accessing tags for OutlineTable HOT 1
- Missing ant Buildlistener class
- Deploy maven plugins to Maven Central
- Step definitions inside jar HOT 6
- Example project 'jamesladd-maven-cuke4duke-jump-start' fails HOT 5
- cuke4duke install fails HOT 6
- better grails example HOT 3
- Deprecate this project more clearly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cuke4duke.