The "I should be on ..." step definition for webrat needs to handle all types of URIs about cucumber-rails

[aslakhellesoy]

Are you suggesting this code as a fix?

[andrewdsmith]

Err... yes! It certainly works on my project where I have paths with query strings and both relative and absolute URIs turning up in current_url; I can't admit to having done any more testing. Let me know if there's anything you'd need me to do to get this accepted.

[aslakhellesoy]

Bugfix: Handle all types of URIs in "I should be on ..." steps. Closed by f13b014.

[andrewdsmith]

Awesome! :-)

[scottj97]

Maybe I don't understand, but I don't see why you want the query string used in this comparison. In theory what page you're on ("Then I should be on ...") should be independent of the query string.

This change broke me because I have a "I should be on the login page" and sometimes my app redirects to the login page with a query string like "?return_to=foo" that I don't care about. It's still the login page whether or not the query string is there.

[andrewdsmith]

Hmmm. I'd not considered this. I have a "page" that uses a query string parameter to distinguish between... err... pages; it's basically a search page and I wanted to assert I was on the right results page. But I see entirely where you're coming from and I could change my routing. If you want to ask Aslak to reverse this then I won't object.

[scottj97]

I would suggest you add a new "Then I should see results for ..." or something like that instead of using the built-in "Then I should be on ..." rule.

I've got a suitable workaround so I don't really care one way or the other.