GithubHelp home page GithubHelp logo

Comments (7)

mozfreddyb avatar mozfreddyb commented on July 4, 2024

Mario suggested doing this in a branch or exploring this using the hooking API, before taking it into DOMPurify.

from dompurify.

cure53 avatar cure53 commented on July 4, 2024

I like the idea but I don't see it arriving in the core anytime soon. However a branch and maybe a plugin or even a split project would be cool.

I am wondering though - how would you image the API to look like?

from dompurify.

mozfreddyb avatar mozfreddyb commented on July 4, 2024
// let's assume these three vars are untrusted
var href = "javascript:alert(1)";
var title = "click me";
var text = "innocent text <script>alert(1)</script>";

whatever.innerHTML = interpolate`<a href='${href}' title='${title}'>${text}</a>`
// returns <a href='' title='click me'>innocent text &lt;script&gt;alert(1)&lt;/script&gt;</a>

from dompurify.

cure53 avatar cure53 commented on July 4, 2024

Would you expect DOMPurify to sanitize the single components or rather the final result?
I'd assume the latter, just to be sure.

from dompurify.

mozfreddyb avatar mozfreddyb commented on July 4, 2024

I have assumed to do the context-aware encoding in DOMPurify, but that's beyond its capabilities and it dawns me that there is very little overlap between my interpolation suggestion and DOMPurify.

Thanks for this good question :-) This will mean my interpolation should really live outside of DOMPurify or use it (at the end) to sanitize the final result..

from dompurify.

cure53 avatar cure53 commented on July 4, 2024

@mozfreddyb Should we close this for now?

from dompurify.

mozfreddyb avatar mozfreddyb commented on July 4, 2024

aye

from dompurify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.