GithubHelp home page GithubHelp logo

Comments (6)

cure53 avatar cure53 commented on July 24, 2024

We have the following option available (rarely used thus maybe not optimal):

// return a DOM instead of an HTML string (default is false)
var clean = DOMPurify.sanitize(dirty, {RETURN_DOM: true});

Would you need an additional flag or another refinement here?

from dompurify.

Joris-van-der-Wel avatar Joris-van-der-Wel commented on July 24, 2024

Oh sorry I missed that.

Two issues/refinements I see:

  • It returns a or element, of which you have to manually move over the children
  • The nodes belong to the internal temporary document of DOMPurify, using these nodes without importNode or adoptNode is against spec, so I would have to do that myself (plus feature detecting which of the two to use).

I can imagine wanting to do this in DOMPurify to make sure the internal document is not exposed and to make sure no exploits are introduced in the adopting step. I can imagine adoptNode preserving the past names map of HTMLFormElement for example (I have not tested if this is true).

from dompurify.

ConradIrwin avatar ConradIrwin commented on July 24, 2024

FWIW I'm putting the returned document inside a sandboxed iframe, so I really like the current API not making any assumptions.

from dompurify.

cure53 avatar cure53 commented on July 24, 2024

@ConradIrwin That's good info, I wasn't sure if people used this option or not. So we shall leave this one as it is.

@Joris-van-der-Wel I would opt for an additional option then:

// return a DocumentFragment instead of an HTML string (default is false)
var clean = DOMPurify.sanitize(dirty, {RETURN_DOM_FRAGMENT: true});

from dompurify.

Joris-van-der-Wel avatar Joris-van-der-Wel commented on July 24, 2024

Sounds good, I'll whip up a PR

from dompurify.

cure53 avatar cure53 commented on July 24, 2024

Thanks :)

from dompurify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.