Flag KEEP_CONTENT has no effect on io.js about dompurify

[cure53]

Btw, are we still good with io.js given that we now utilize DOMParser? My first (superficial) research says yes, but I am not sure...

https://www.npmjs.com/package/xmldom

[cure53]

@fhemberger @Joris-van-der-Wel Is this still an issue?

[Joris-van-der-Wel]

Well, insertAdjacentHTML is still not supported in jsdom. I want to add it eventually (it is not that hard), but I am busy with some other jsdom things first.

[cure53]

Oh, okay, we'll leave this open then. Thx for the update :)

[cure53]

Hi all,

@Joris-van-der-Wel Is this issue fixed? I ran into this - looks a bit like it :)

[cure53]

Closing this for inactivity.

[Joris-van-der-Wel]

I can confirm the KEEP_CONTENT test are passing. Although strictly speaking, it does not work in io.js because jsdom now requires node.js 4.

[cure53]

We should probably update the README.md to reflect this. So instead of the mentioned io.js, now, Node v4.0.0 w. jsdom is known to work?

[Joris-van-der-Wel]

Yep:
jsdom 8 for insertAdjacentHTML: https://github.com/tmpvar/jsdom/blob/master/Changelog.md#800
jsdom 7 requires node 4: https://github.com/tmpvar/jsdom/blob/master/Changelog.md#700