Complete quoting for parameters of some CMake commands about curl

[snikulov]

I'll check it soon.

[bagder]

Anything?

[snikulov]

I think we should ask @bradking for this.
Personally I see no reason to put quotes around all variables/path usage.
Yes, it can help us to avoid some issues with long path in future, but no specific example/test case come into my mind right now.
Perhaps we should close this issue and solve the issues when they are arrives with exact problem description.

[bradking]

For reference, the official documentation of the cmake language command arguments is here:

http://www.cmake.org/cmake/help/v3.2/manual/cmake-language.7.html#command-arguments

It explains how quoted arguments are always interpreted as a single value and how unquoted arguments get divided on ; into zero or more arguments.

While the issue raised is technically correct, we commonly leave out quotes when the value is expected to be a filesystem path rather than arbitrary text or a list. Even CMake's own source does this. One of the reasons ; was chosen as the list separator for unquoted argument expansion is that it is not allowed in filesystem paths on Windows and is very obscure elsewhere.

[bagder]

Thanks for the excellent feedback. Then I suggest we leave it as-is since there have not been any actual problems reported on this, nor do we really expect any.