Erroneous debug text when paired with OpenSSL 1.0.2 about curl

[michael-o]

I can confirm this on 9.3-STABLE with 7.42.0.

[bagder]

Thanks, fix landed in 690317a

[michael-o]

I will give it a try tomorrow.

[jay]

Thanks for investigating and fixing this Daniel. Using OpenSSL 1.0.2a and curl commit 8a35211 2015-05-04 this is the output I get now in Windows Visual Studio 2010 configuration 'DLL Debug - DLL OpenSSL' (either Win32 or x64) when I connect to https://google.com:

* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* STATE: SENDPROTOCONNECT => PROTOCONNECT handle 0x1e9f788; line 1210 (connection #0)
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):

There is no [xx bytes of data] message any longer. I think it looks cleaner this way but I'm not sure if that's what you intended because there is still a colon at the end of each action line.

[bagder]

Really? I don't see how this change could have that effect (and my unpatched 7.42.1 comparison output doesn't show any such "xx bytes of data" output). This change should only remove "unknown" lines and change the explanatory texts somewhat. Or have I missed something?

If you need the full details I'd say that --trace and --trace-ascii are the better options.

[jay]

Nevermind I was comparing it against the OP's output instead of my own. I tried the commit before your changes and I don't get the [data] messages there either. Also I checked the sourceforge bug and I didn't get [data] there either.

[bagder]

Ok, goodie. Then I wasn't hallucinating too badly! =)

[michael-o]

Looks ok now:

* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /usr/local/share/certs/combined-ca.pem
  CApath: none
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
} [5 bytes data]
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.2 (IN), TLS handshake, Server hello (2):
{ [98 bytes data]
* TLSv1.2 (IN), TLS handshake, Certificate (11):
{ [1873 bytes data]
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
{ [589 bytes data]
* TLSv1.2 (IN), TLS handshake, Server finished (14):
{ [4 bytes data]
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
} [70 bytes data]
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
} [1 bytes data]
* TLSv1.2 (OUT), TLS handshake, Finished (20):
} [16 bytes data]
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
{ [1 bytes data]
* TLSv1.2 (IN), TLS handshake, Finished (20):
{ [16 bytes data]
* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* ALPN, server did not agree to a protocol
* Server certificate:

Is the colon referring to the byte data below? If not, I'd rather remove that.

[michael-o]

Just checked on another OS with OpenSSL 0.9.8. It's fine too.